You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/10/02 02:44:12 UTC
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull
request #4664: Support other filesystems for Pinot Hadoop job
Jackie-Jiang commented on a change in pull request #4664: Support other filesystems for Pinot Hadoop job
URL: https://github.com/apache/incubator-pinot/pull/4664#discussion_r330352868
##########
File path: pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/BaseSegmentJob.java
##########
@@ -107,8 +107,14 @@ protected Path getPathFromProperty(String key) {
protected List<Path> getDataFilePaths(Path pathPattern)
throws IOException {
List<Path> tarFilePaths = new ArrayList<>();
- FileSystem fileSystem = FileSystem.get(_conf);
- getDataFilePathsHelper(fileSystem, fileSystem.globStatus(pathPattern), tarFilePaths);
+ FileSystem fileSystem = FileSystem.get(pathPattern.toUri(), _conf);
+ _logger.info("Using filesystem: {}", fileSystem);
+ final FileStatus[] fileStatuses = fileSystem.globStatus(pathPattern);
Review comment:
(nit) remove the final
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org