You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Oliver Heger (JIRA)" <ji...@apache.org> on 2015/10/05 22:06:26 UTC
[jira] [Resolved] (CONFIGURATION-612)
BuilderConfigurationWrapperFactory should support ImmutableConfiguration
[ https://issues.apache.org/jira/browse/CONFIGURATION-612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oliver Heger resolved CONFIGURATION-612.
----------------------------------------
Resolution: Fixed
Fix Version/s: 2.0
Patch applied (with minor changes) in revision 1706912. Many thanks again!
The problem with {{TestDefaultFileSystem}} had already been fixed, so this part was omitted.
The change of the return type of ConfigurationBuilder.getConfiguration() certainly makes sense. However, there is currently no builder implementation which actually returns a real {{ImmutableConfiguration}}. It would probably be good to create a special {{ImmutableConfigurationBuilder}} which wraps a normal builder and then transforms the resulting configuration into an immutable one. But this is a story for another ticket.
> BuilderConfigurationWrapperFactory should support ImmutableConfiguration
> ------------------------------------------------------------------------
>
> Key: CONFIGURATION-612
> URL: https://issues.apache.org/jira/browse/CONFIGURATION-612
> Project: Commons Configuration
> Issue Type: Improvement
> Reporter: Jon Weygandt
> Fix For: 2.0
>
> Attachments: CONFIGURATION-612-v2.patch, CONFIGURATION-612.patch
>
>
> Since ImmutableConfigurations have been introduced in 2.0, the BuilderConfigurationWrapperFactory should support these types.
> The patch attached to this issue changes BuilderConfigurationWrapperFactory.createBuilderConfigurationWrapper's T to <T extends ImmutableConfiguration> along with the ripple of changes to associated classes.
> Also updated is the documentation on the use of the wrapper.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)