Re: [PR] AIP-66: Make DAG callbacks bundle aware [airflow]

["jedcunningham (via GitHub)" <gi...@apache.org>]

jedcunningham commented on code in PR #45860:
URL: https://github.com/apache/airflow/pull/45860#discussion_r1939783721


##########
airflow/triggers/base.py:
##########
@@ -215,9 +215,11 @@ def _submit_callback_if_necessary(self, *, task_instance: TaskInstance, session)
         """Submit a callback request if the task state is SUCCESS or FAILED."""
         if self.task_instance_state in (TaskInstanceState.SUCCESS, TaskInstanceState.FAILED):
             request = TaskCallbackRequest(
-                full_filepath=task_instance.dag_model.fileloc,
+                filepath=task_instance.dag_model.fileloc,
                 ti=task_instance,
                 task_callback_type=self.task_instance_state,
+                bundle_name=task_instance.dag_model.bundle_name,
+                bundle_version=task_instance.dag_model.bundle_version,

Review Comment:
   (unresolving, looks like this got switched back)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org