[GitHub] [apisix] tokers commented on a diff in pull request #7690: fix(openid-connect): Fix the default 'redirect_uri' (#2426)

[GitBox <gi...@apache.org>]

tokers commented on code in PR #7690:
URL: https://github.com/apache/apisix/pull/7690#discussion_r946525140


##########
apisix/plugins/openid-connect.lua:
##########
@@ -65,7 +65,7 @@ local schema = {
         },
         redirect_uri = {
             type = "string",
-            description = "use ngx.var.request_uri if not configured"
+            description = "auto append '.apisix/redirect' if not configured"

Review Comment:
   But it cannot make sure the new URI will be matched by the same route, it actually adds an implicit condition that the route match type is prefix instead of exact.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org