You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/28 21:51:00 UTC

[GitHub] [pulsar] dlg99 opened a new pull request #14916: Kafka Connect Adaptor: handle null offsets from kafka connector

dlg99 opened a new pull request #14916:
URL: https://github.com/apache/pulsar/pull/14916


   ### Motivation
   
   Some Kafka connectors (e.g. JMS) return null as an offset value because underlying system does not support. 
   
   ### Modifications
   
   Handle attempt to set null as a partition offset; set it to message.earliest to avoid NPEs (actual value does not matter AFAICT)
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change added unit tests
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
   NO
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
   Check the box below or label this PR directly (if you have committer privilege).
   
   Need to update docs? 
   
   - [ ] `doc-required` 
     
     (If you need help on updating docs, create a doc issue)
     
   - [x] `no-need-doc` 
     
     (Please explain why)
     
   - [ ] `doc` 
     
     (If this PR contains doc changes)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] dlg99 commented on pull request #14916: Kafka Connect Adaptor: handle null offsets from kafka connector

Posted by GitBox <gi...@apache.org>.
dlg99 commented on pull request #14916:
URL: https://github.com/apache/pulsar/pull/14916#issuecomment-1081336214


   RabbitMQ integration test is failing (flaking?), AFAICT it is not affected by my changes. 
   I see the same test failing on PR https://github.com/apache/pulsar/pull/14912


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #14916: Kafka Connect Adaptor: handle null offsets from kafka connector

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #14916:
URL: https://github.com/apache/pulsar/pull/14916#issuecomment-1084529653


   @dlg99 please rebase onto latest master, now CI should be in good shape


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org