You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/04/01 14:32:22 UTC

[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #8940: assert: Replace CONFIG_BOARD_ASSERT_RESET_VALUE with BOARDIOC_SOFTRESETCAUSE_ASSERT

xiaoxiang781216 opened a new pull request, #8940:
URL: https://github.com/apache/nuttx/pull/8940

   ## Summary
   
   unify the reset cause value
   
   ## Impact
   
   Minor
   
   ## Testing
   
   CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8940: assert: Replace CONFIG_BOARD_ASSERT_RESET_VALUE with BOARDIOC_SOFTRESETCAUSE_ASSERT

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #8940:
URL: https://github.com/apache/nuttx/pull/8940#issuecomment-1494664613

   > Changing this API is not OK. It breaks systems that pass the value CONFIG_BOARD_ASSERT_RESET_VALUE to mean s something. 0 reboot, 1 boot to ROM... etc
   > 
   
   > Once before this was changed: the default was moved from 0 to 1. That broke all code using the value.
   
   But, the default value is 1 not 0:
   https://github.com/apache/nuttx/pull/8940/files#diff-60cc096e3a9b22a769602cbbc3b0f5e7731e72db7b0338da04fcf665ed753b64L4064
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] xiaoxiang781216 closed pull request #8940: assert: Replace CONFIG_BOARD_ASSERT_RESET_VALUE with BOARDIOC_SOFTRESETCAUSE_ASSERT

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 closed pull request #8940: assert: Replace CONFIG_BOARD_ASSERT_RESET_VALUE with BOARDIOC_SOFTRESETCAUSE_ASSERT
URL: https://github.com/apache/nuttx/pull/8940


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8940: assert: Replace CONFIG_BOARD_ASSERT_RESET_VALUE with BOARDIOC_SOFTRESETCAUSE_ASSERT

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #8940:
URL: https://github.com/apache/nuttx/pull/8940#issuecomment-1496136783

   > > Ok, I fix the problem with a different method, @davids5 please review this patch: #8956.
   > 
   > I think I must not be explaining the issues clearly. Let me try again
   > 
   > We had a Kconfig value that could be set to a **user defined value** - say 1289. Now it will be 1.
   > 
   > The value passed has to be the 'user defined value' not a constant from the system that is subject to change and can not be changed with Kconfig.
   > 
   > Does that make sense?
   
   All you described here isn't changed, I will close this PR to avoid the confusion. Let's discuss in https://github.com/apache/nuttx/pull/8956.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8940: assert: Replace CONFIG_BOARD_ASSERT_RESET_VALUE with BOARDIOC_SOFTRESETCAUSE_ASSERT

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #8940:
URL: https://github.com/apache/nuttx/pull/8940#issuecomment-1494860709

   Ok, I fix the problem with a different method, @davids5 please review this patch: https://github.com/apache/nuttx/pull/8956.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] davids5 commented on pull request #8940: assert: Replace CONFIG_BOARD_ASSERT_RESET_VALUE with BOARDIOC_SOFTRESETCAUSE_ASSERT

Posted by "davids5 (via GitHub)" <gi...@apache.org>.
davids5 commented on PR #8940:
URL: https://github.com/apache/nuttx/pull/8940#issuecomment-1495682152

   > Ok, I fix the problem with a different method, @davids5 please review this patch: #8956.
   
   I think I must not be explaining the issues clearly. Let me try again
   
   We had a Kconfig value that could be set to a **user defined value** - say 1289. Now it will be 1. 
   
   The value passed has to be the 'user defined value' not a constant from the system that is subject to change and can not be changed with Kconfig.
   
   Does that make sence?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org