You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/05/27 20:39:13 UTC
[jira] [Commented] (FLINK-3981) Don't log duplicate TaskManager
registrations as exceptions
[ https://issues.apache.org/jira/browse/FLINK-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304733#comment-15304733 ]
ASF GitHub Bot commented on FLINK-3981:
---------------------------------------
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2045
[FLINK-3981] don't log duplicate TaskManager registrations
Duplicate TaskManager registrations shouldn't be logged with Exceptions
in the ResourceManager. Duplicate registrations can happen if the
TaskManager sends out registration messages too fast when the actual
reply is not lost but still in transit.
The ResourceManager should simply acknowledge the duplicate
registrations, leaving it up to the JobManager to decide how to treat
the duplicate registrations (currently it will send an AlreadyRegistered
to the TaskManager).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/flink FLINK-3981
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2045.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2045
----
commit 8106ab460920ccea2a96e90c3a778d7acac0c672
Author: Maximilian Michels <mx...@apache.org>
Date: 2016-05-27T19:02:38Z
[FLINK-3981] don't log duplicate TaskManager registrations
Duplicate TaskManager registrations shouldn't be logged with Exceptions
in the ResourceManager. Duplicate registrations can happen if the
TaskManager sends out registration messages too fast when the actual
reply is not lost but still in transit.
The ResourceManager should simply acknowledge the duplicate
registrations, leaving it up to the JobManager to decide how to treat
the duplicate registrations (currently it will send an AlreadyRegistered
to the TaskManager).
----
> Don't log duplicate TaskManager registrations as exceptions
> -----------------------------------------------------------
>
> Key: FLINK-3981
> URL: https://issues.apache.org/jira/browse/FLINK-3981
> Project: Flink
> Issue Type: Bug
> Components: ResourceManager
> Affects Versions: 1.1.0
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Minor
> Labels: test-stability
> Fix For: 1.1.0
>
>
> Duplicate TaskManager registrations shouldn't be logged with Exceptions in the ResourceManager. Duplicate registrations can happen if the TaskManager sends out registration messages too fast when the actual reply is not lost but still in transit.
> The ResourceManager should simply acknowledge the duplicate registrations, leaving it up to the JobManager to decide how to treat the duplicate registrations (currently it will send an AlreadyRegistered to the TaskManager).
> This change also affects our test stability because the Yarn tests check the logs for exceptions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)