[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8685: ARROW-10216: [Rust] Simd implementation for primitive min/max kernels

[GitBox <gi...@apache.org>]

jorgecarleitao commented on a change in pull request #8685:
URL: https://github.com/apache/arrow/pull/8685#discussion_r537246148



##########
File path: rust/arrow/src/datatypes.rs
##########
@@ -618,7 +628,7 @@ macro_rules! make_numeric_type {
             fn mask_from_u64(mask: u64) -> Self::SimdMask {
                 match Self::lanes() {
                     8 => {
-                        let vecidx = i64x8::new(128, 64, 32, 16, 8, 4, 2, 1);
+                        let vecidx = i64x8::new(1, 2, 4, 8, 16, 32, 64, 128);

Review comment:
       Maybe a line comment before this assignment could help others in understanding these numbers?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org