[GitHub] [spark] Ngone51 edited a comment on pull request #34043: [SPARK-36782][CORE] Avoid blocking dispatcher-BlockManagerMaster during UpdateBlockInfo

[GitBox <gi...@apache.org>]

Ngone51 edited a comment on pull request #34043:
URL: https://github.com/apache/spark/pull/34043#issuecomment-924860943


   > With the proposed changes I suppose we don't actually delegate it to the DAGScheduler (as suggested by @Ngone51) but to the block-manager-ask-thread-pool. If this is undesired, I believe there's a more fundamental change needed?
   
   @f-thiele  We can get the `dagScheduler` by `BlockManagerMasterEndpoint.listenerBus.sparkContext.dagScheduler` (should expose  `sparkContext` in `listenerBus` as `private[spark]` ) and add a new function in `dagScheduler` to handle the specific `UpdateBlockInfo` of migrated shuffle block. (You could follow `dagScheduler.executorAdded` as an example). So I actually don't expect much more fundamental changes here.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org