You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@incubator.apache.org by Sheng Zha <zh...@apache.org> on 2021/01/13 02:02:16 UTC
Re: [VOTE] Release Apache MXNet (incubating) version 1.8.0.rc2
Hi,
Following up on the difficulty of auditing licenses for files in MXNet, I opened a pull request to reorganize and capture the licenses [1]. As the PR is still open and not yet posted to 1.8.x, I'm mainly looking for feedback on whether the update looks reasonable or if there's further improvement needed.
I'd really appreciate it if experienced members could help take a look and see if we are on the right track. Thanks!
Best,
Sheng
[1] https://github.com/apache/incubator-mxnet/pull/19743/files#diff-c4d3e0b0418ccd980c7413602547bf82a880983322095e85ef4b76f863b656a9
On 2020/11/17 17:09:41, Dave Fisher <wa...@apache.org> wrote:
> Hi -
>
> It is really great that you did all the license work. It’s just hard for an IPMC member to audit it.
>
> The rat-excludes file is quite large and not in an obvious location. It would be helpful to organize it and add comments about why certain files and globs are included in the excludes.
>
> eg.
>
> # why are these directories excluded - what’s the license? Does RAT not recognize it?
> image-classification/*
> ctc_include/*
> dlpack/*
> dmlc-core/*
> googletest/*
> intgemm/*
> mkldnn/*
> nvidia_cub/*
> onnx-tensorrt/*
> openmp/*
>
> This was not an exhaustive sample.
>
> Regards,
> Dave
>
> > On Nov 16, 2020, at 12:56 PM, Sheng Zha <zh...@apache.org> wrote:
> >
> > Hi Dave,
> >
> > Thank you very much for the help and support. In MXNet we do use Apache Rat as part of our CI, and it's run on every pull request [1]. When executing license check, we excluded some file types (e.g. intermediate outputs from builds, lock files, etc.), and some third-party modules that we bundle in source distribution [2] (as license headers are missing in some of their files). For third-party licenses, as part of 1.8.0.rc2 check, we went through a thorough review of third-party files and assembled their licenses into our LICENSE file [3]. The last effort should have covered those that show as unknown license from a complete Rat check.
> >
> > In the meantime, in future releases we will explore minimizing the bundled third-party code to completely resolve any such potential issue and try to make sure that we have control to the license headers of all files we bundle. Let us know if there is any suggestion to help us earn +1s from this list.
> >
> > Thanks,
> > Sheng
> >
> > [1] https://github.com/apache/incubator-mxnet/blob/6bc064771d805163cd22123e9b3ec25bb55341d3/ci/docker/runtime_functions.sh#L1013-L1034
> > [2] https://github.com/apache/incubator-mxnet/blob/6bc064771d805163cd22123e9b3ec25bb55341d3/tests/nightly/apache_rat_license_check/rat-excludes
> > [3] https://github.com/apache/incubator-mxnet/issues/19427
> >
> > On 2020/11/16 20:17:39, Dave Fisher <wa...@apache.org> wrote:
> >> Hi -
> >>
> >> I went through the exercise, but I’m +0 as I really cannot handle reviewing the license for 3000 files.
> >>
> >> % java -jar ~/Development/apache-rat-0.13/apache-rat-0.13.jar -d . | more
> >>
> >> *****************************************************
> >> Summary
> >> -------
> >> Generated at: 2020-11-16T12:06:53-08:00
> >>
> >> Notes: 67
> >> Binaries: 2609
> >> Archives: 0
> >> Standards: 10304
> >>
> >> Apache Licensed: 7091
> >> Generated Documents: 0
> >>
> >> JavaDocs are generated, thus a license header is optional.
> >> Generated files do not require license headers.
> >>
> >> 3167 Unknown Licenses
> >>
> >> Please learn how to use Apache Rat and make it recognize all those unknown licenses …
> >>
> >> Thanks,
> >> Dave
> >>
> >>
> >>> On Nov 1, 2020, at 9:01 PM, Skalicky, Sam <ss...@amazon.com.INVALID> wrote:
> >>>
> >>> Dear community,
> >>>
> >>> This is a call for a releasing Apache MXNet (incubating) 1.8.0, release candidate 2.
> >>>
> >>> Apache MXNet (incubating) community has voted and approved the release.
> >>>
> >>> Vote thread:
> >>> https://lists.apache.org/thread.html/r7db67b84ff410dca63a678c4ec8f8a2a13cbf33fe1cee3252d5598f0%40%3Cdev.mxnet.apache.org%3E
> >>>
> >>> Result thread:
> >>> https://lists.apache.org/thread.html/r5c62a443811785e8785569d27403982068df724b63e6ac363c1bf741%40%3Cdev.mxnet.apache.org%3E
> >>>
> >>> The source tarball, including signatures, digests, etc. can be found at:
> >>> https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.8.0.rc2
> >>>
> >>> The tag to be voted upon is 1.8.0.rc1:
> >>> https://github.com/apache/incubator-mxnet/releases/tag/1.8.0.rc2
> >>>
> >>> The release hash is 6d5d8b9c6c8fca0d192ec99be1ccfb364327a3ad:
> >>> https://github.com/apache/incubator-mxnet/commit/6d5d8b9c6c8fca0d192ec99be1ccfb364327a3ad
> >>>
> >>> KEYS file available:
> >>> https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS
> >>>
> >>> For information about the contents of this release, see:
> >>> https://cwiki.apache.org/confluence/display/MXNET/1.8.0+Release+Notes
> >>>
> >>> Here are the changes comparing to 1.8.0.rc1:
> >>> * Updated LICENSE for all submodules
> >>> * Changed intgemm to a submodule instead of fetch
> >>> * Updated DISCLAIMER
> >>>
> >>> The vote will be open for 72 hours.
> >>> [ ] +1 release this package as #########
> >>> [ ] +0 no opinion
> >>> [ ] -1 do not release this package because...
> >>>
> >>> Best regards,
> >>> Sam Skalicky
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> >> For additional commands, e-mail: general-help@incubator.apache.org
> >>
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache MXNet (incubating) version 1.8.0.rc2
Posted by Sheng Zha <zh...@apache.org>.
Update: per comment from Sam, the rat-excludes allowlist is moved to top-level in MXNet repo for discoverability.
Thanks,
Sheng
On 2021/01/13 02:02:16, Sheng Zha <zh...@apache.org> wrote:
> Hi,
>
> Following up on the difficulty of auditing licenses for files in MXNet, I opened a pull request to reorganize and capture the licenses [1]. As the PR is still open and not yet posted to 1.8.x, I'm mainly looking for feedback on whether the update looks reasonable or if there's further improvement needed.
>
> I'd really appreciate it if experienced members could help take a look and see if we are on the right track. Thanks!
>
> Best,
> Sheng
>
> [1] https://github.com/apache/incubator-mxnet/pull/19743/files#diff-c4d3e0b0418ccd980c7413602547bf82a880983322095e85ef4b76f863b656a9
>
> On 2020/11/17 17:09:41, Dave Fisher <wa...@apache.org> wrote:
> > Hi -
> >
> > It is really great that you did all the license work. It’s just hard for an IPMC member to audit it.
> >
> > The rat-excludes file is quite large and not in an obvious location. It would be helpful to organize it and add comments about why certain files and globs are included in the excludes.
> >
> > eg.
> >
> > # why are these directories excluded - what’s the license? Does RAT not recognize it?
> > image-classification/*
> > ctc_include/*
> > dlpack/*
> > dmlc-core/*
> > googletest/*
> > intgemm/*
> > mkldnn/*
> > nvidia_cub/*
> > onnx-tensorrt/*
> > openmp/*
> >
> > This was not an exhaustive sample.
> >
> > Regards,
> > Dave
> >
> > > On Nov 16, 2020, at 12:56 PM, Sheng Zha <zh...@apache.org> wrote:
> > >
> > > Hi Dave,
> > >
> > > Thank you very much for the help and support. In MXNet we do use Apache Rat as part of our CI, and it's run on every pull request [1]. When executing license check, we excluded some file types (e.g. intermediate outputs from builds, lock files, etc.), and some third-party modules that we bundle in source distribution [2] (as license headers are missing in some of their files). For third-party licenses, as part of 1.8.0.rc2 check, we went through a thorough review of third-party files and assembled their licenses into our LICENSE file [3]. The last effort should have covered those that show as unknown license from a complete Rat check.
> > >
> > > In the meantime, in future releases we will explore minimizing the bundled third-party code to completely resolve any such potential issue and try to make sure that we have control to the license headers of all files we bundle. Let us know if there is any suggestion to help us earn +1s from this list.
> > >
> > > Thanks,
> > > Sheng
> > >
> > > [1] https://github.com/apache/incubator-mxnet/blob/6bc064771d805163cd22123e9b3ec25bb55341d3/ci/docker/runtime_functions.sh#L1013-L1034
> > > [2] https://github.com/apache/incubator-mxnet/blob/6bc064771d805163cd22123e9b3ec25bb55341d3/tests/nightly/apache_rat_license_check/rat-excludes
> > > [3] https://github.com/apache/incubator-mxnet/issues/19427
> > >
> > > On 2020/11/16 20:17:39, Dave Fisher <wa...@apache.org> wrote:
> > >> Hi -
> > >>
> > >> I went through the exercise, but I’m +0 as I really cannot handle reviewing the license for 3000 files.
> > >>
> > >> % java -jar ~/Development/apache-rat-0.13/apache-rat-0.13.jar -d . | more
> > >>
> > >> *****************************************************
> > >> Summary
> > >> -------
> > >> Generated at: 2020-11-16T12:06:53-08:00
> > >>
> > >> Notes: 67
> > >> Binaries: 2609
> > >> Archives: 0
> > >> Standards: 10304
> > >>
> > >> Apache Licensed: 7091
> > >> Generated Documents: 0
> > >>
> > >> JavaDocs are generated, thus a license header is optional.
> > >> Generated files do not require license headers.
> > >>
> > >> 3167 Unknown Licenses
> > >>
> > >> Please learn how to use Apache Rat and make it recognize all those unknown licenses …
> > >>
> > >> Thanks,
> > >> Dave
> > >>
> > >>
> > >>> On Nov 1, 2020, at 9:01 PM, Skalicky, Sam <ss...@amazon.com.INVALID> wrote:
> > >>>
> > >>> Dear community,
> > >>>
> > >>> This is a call for a releasing Apache MXNet (incubating) 1.8.0, release candidate 2.
> > >>>
> > >>> Apache MXNet (incubating) community has voted and approved the release.
> > >>>
> > >>> Vote thread:
> > >>> https://lists.apache.org/thread.html/r7db67b84ff410dca63a678c4ec8f8a2a13cbf33fe1cee3252d5598f0%40%3Cdev.mxnet.apache.org%3E
> > >>>
> > >>> Result thread:
> > >>> https://lists.apache.org/thread.html/r5c62a443811785e8785569d27403982068df724b63e6ac363c1bf741%40%3Cdev.mxnet.apache.org%3E
> > >>>
> > >>> The source tarball, including signatures, digests, etc. can be found at:
> > >>> https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.8.0.rc2
> > >>>
> > >>> The tag to be voted upon is 1.8.0.rc1:
> > >>> https://github.com/apache/incubator-mxnet/releases/tag/1.8.0.rc2
> > >>>
> > >>> The release hash is 6d5d8b9c6c8fca0d192ec99be1ccfb364327a3ad:
> > >>> https://github.com/apache/incubator-mxnet/commit/6d5d8b9c6c8fca0d192ec99be1ccfb364327a3ad
> > >>>
> > >>> KEYS file available:
> > >>> https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS
> > >>>
> > >>> For information about the contents of this release, see:
> > >>> https://cwiki.apache.org/confluence/display/MXNET/1.8.0+Release+Notes
> > >>>
> > >>> Here are the changes comparing to 1.8.0.rc1:
> > >>> * Updated LICENSE for all submodules
> > >>> * Changed intgemm to a submodule instead of fetch
> > >>> * Updated DISCLAIMER
> > >>>
> > >>> The vote will be open for 72 hours.
> > >>> [ ] +1 release this package as #########
> > >>> [ ] +0 no opinion
> > >>> [ ] -1 do not release this package because...
> > >>>
> > >>> Best regards,
> > >>> Sam Skalicky
> > >>
> > >>
> > >> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > >> For additional commands, e-mail: general-help@incubator.apache.org
> > >>
> > >>
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: general-help@incubator.apache.org
> > >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org