[GitHub] [spark] zero323 commented on pull request #36547: [SPARK-39197][PYTHON] Implement `skipna` parameter of `GroupBy.all`

[GitBox <gi...@apache.org>]

zero323 commented on PR #36547:
URL: https://github.com/apache/spark/pull/36547#issuecomment-1128565616

   By itself LGTM. To concur with others, I also don't see shading issue and if it there was one, we're not introducing a new method here and changing a name at this point would be a breaking change., even if we ignore Pandas parity.
   
   Speaking about parity ‒ did we intentionally diverge from Pandas contract in the original implementation?  Boolean cast not only is not going to cover all types, but also yield different results in some cases (not something to be fixed here, if at all, just want to clarify things to decide if we need a new JIRA ticket for that).
   
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org