You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/06/04 21:36:00 UTC
[kudu-CR] thirdparty: fix memkind build race
Hello ye yuqiang,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13513
to review the following change.
Change subject: thirdparty: fix memkind build race
......................................................................
thirdparty: fix memkind build race
On rare occasions, the libmemkind.a produced by the memkind build was
missing its jemalloc symbols. This then led to Kudu linkage failures if Kudu
was using static linkage (i.e. in RELEASE builds).
This turned out to be due to a build race of our own making: we can't ask
make to run the install-exec and static_lib targets simultaneously. Both
targets depend on libmemkind.a, but static_lib performs some important
post-processing on libmemkind.a that must complete before install-exec
copies libmemkind.a into the installed directory. And by offering both
targets on the command line, make can run them in parallel once their common
dependency (libmemkind.a) is built.
Change-Id: I1242e733e7d282d1e7471656ea81349be427aa1f
---
M thirdparty/build-definitions.sh
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/13513/1
--
To view, visit http://gerrit.cloudera.org:8080/13513
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1242e733e7d282d1e7471656ea81349be427aa1f
Gerrit-Change-Number: 13513
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: ye yuqiang <yu...@intel.com>
[kudu-CR] thirdparty: fix memkind build race
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13513 )
Change subject: thirdparty: fix memkind build race
......................................................................
thirdparty: fix memkind build race
On rare occasions, the libmemkind.a produced by the memkind build was
missing its jemalloc symbols. This then led to Kudu linkage failures if Kudu
was using static linkage (i.e. in RELEASE builds).
This turned out to be due to a build race of our own making: we can't ask
make to run the install-exec and static_lib targets simultaneously. Both
targets depend on libmemkind.a, but static_lib performs some important
post-processing on libmemkind.a that must complete before install-exec
copies libmemkind.a into the installed directory. And by offering both
targets on the command line, make can run them in parallel once their common
dependency (libmemkind.a) is built.
Change-Id: I1242e733e7d282d1e7471656ea81349be427aa1f
Reviewed-on: http://gerrit.cloudera.org:8080/13513
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M thirdparty/build-definitions.sh
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13513
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1242e733e7d282d1e7471656ea81349be427aa1f
Gerrit-Change-Number: 13513
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: ye yuqiang <yu...@intel.com>
[kudu-CR] thirdparty: fix memkind build race
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13513 )
Change subject: thirdparty: fix memkind build race
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13513
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1242e733e7d282d1e7471656ea81349be427aa1f
Gerrit-Change-Number: 13513
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: ye yuqiang <yu...@intel.com>
Gerrit-Comment-Date: Tue, 04 Jun 2019 21:48:12 +0000
Gerrit-HasComments: No