You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "asia-zengtao (via GitHub)" <gi...@apache.org> on 2023/06/26 02:46:52 UTC

[GitHub] [iotdb] asia-zengtao opened a new pull request, #10317: Update TsFileOutputFormat.java

asia-zengtao opened a new pull request, #10317:
URL: https://github.com/apache/iotdb/pull/10317

   Exception handling is improved by providing specific error messages when dealing with URISyntaxException


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou commented on a diff in pull request #10317: Update TsFileOutputFormat.java

Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou commented on code in PR #10317:
URL: https://github.com/apache/iotdb/pull/10317#discussion_r1275798714


##########
.github/workflows/build.yml:
##########


Review Comment:
   Empty file?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] asia-zengtao commented on a diff in pull request #10317: Update TsFileOutputFormat.java

Posted by "asia-zengtao (via GitHub)" <gi...@apache.org>.
asia-zengtao commented on code in PR #10317:
URL: https://github.com/apache/iotdb/pull/10317#discussion_r1251391731


##########
pom.xml:
##########
@@ -124,6 +124,8 @@
     </modules>
     <!-- Properties Management -->
     <properties>
+        <sonar.organization>asia-zengtao</sonar.organization>
+        <sonar.host.url>https://sonarcloud.io</sonar.host.url>

Review Comment:
   Ok I will remove it! thanks !



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou commented on a diff in pull request #10317: Update TsFileOutputFormat.java

Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou commented on code in PR #10317:
URL: https://github.com/apache/iotdb/pull/10317#discussion_r1243096268


##########
.github/workflows/build.yml:
##########


Review Comment:
   Consider remove this workflow file?



##########
.github/workflows/build.yml:
##########


Review Comment:
   Consider removing this workflow file?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou commented on a diff in pull request #10317: Update TsFileOutputFormat.java

Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou commented on code in PR #10317:
URL: https://github.com/apache/iotdb/pull/10317#discussion_r1243096566


##########
pom.xml:
##########
@@ -124,6 +124,8 @@
     </modules>
     <!-- Properties Management -->
     <properties>
+        <sonar.organization>asia-zengtao</sonar.organization>
+        <sonar.host.url>https://sonarcloud.io</sonar.host.url>

Review Comment:
   remove it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org