You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/22 10:49:40 UTC

[GitHub] [airflow] turbaszek commented on a change in pull request #11743: Google Memcached hooks - improve protobuf messages handling

turbaszek commented on a change in pull request #11743:
URL: https://github.com/apache/airflow/pull/11743#discussion_r510064505



##########
File path: airflow/providers/google/cloud/hooks/cloud_memorystore.py
##########
@@ -572,7 +571,7 @@ def _append_label(instance: cloud_memcache.Instance, key: str, val: str) -> clou
     @staticmethod
     def proto_message_to_dict(message: proto.Message) -> dict:
         """Helper method to parse protobuf message to dictionary."""
-        return json.loads(message.__class__.to_json(message))
+        return message.__class__.to_dict(message)

Review comment:
       Can you add comments in the code explaining why? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org