You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org> on 2009/01/30 10:45:59 UTC

[jira] Created: (SOLR-996) Improve Evaluator API

Improve Evaluator API
---------------------

                 Key: SOLR-996
                 URL: https://issues.apache.org/jira/browse/SOLR-996
             Project: Solr
          Issue Type: Improvement
          Components: contrib - DataImportHandler
    Affects Versions: 1.3
            Reporter: Shalin Shekhar Mangar
            Assignee: Shalin Shekhar Mangar
            Priority: Minor
             Fix For: 1.4


An Evaluator does not know about the Context object which limits use-cases. For example, the use-case given by Gregg in solr-user -- http://markmail.org/thread/pu3z27lreefbbkin

We can add the evaluate method and pass in the Context object. It is a non back-compatible change but since the Evaluator is marked as experimental and it's API has never been documented on the wiki, it should be fine.

We should also rename it to Function to be consistent with the dataimporter.functions namespace it is used with.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-996) Improve Evaluator API

Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shalin Shekhar Mangar updated SOLR-996:
---------------------------------------

    Attachment: SOLR-996.patch

The previous patch had missed a few changes. I'll commit this shortly.

> Improve Evaluator API
> ---------------------
>
>                 Key: SOLR-996
>                 URL: https://issues.apache.org/jira/browse/SOLR-996
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.3
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-996.patch, SOLR-996.patch, SOLR-996.patch
>
>
> An Evaluator does not know about the Context object which limits use-cases. For example, the use-case given by Gregg in solr-user -- http://markmail.org/thread/pu3z27lreefbbkin
> We can add the evaluate method and pass in the Context object. It is a non back-compatible change but since the Evaluator is marked as experimental and it's API has never been documented on the wiki, it should be fine.
> We should also rename it to Function to be consistent with the dataimporter.functions namespace it is used with.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SOLR-996) Improve Evaluator API

Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shalin Shekhar Mangar resolved SOLR-996.
----------------------------------------

    Resolution: Fixed

Committed revision 745734.

Thanks Noble!

> Improve Evaluator API
> ---------------------
>
>                 Key: SOLR-996
>                 URL: https://issues.apache.org/jira/browse/SOLR-996
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.3
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-996.patch, SOLR-996.patch, SOLR-996.patch
>
>
> An Evaluator does not know about the Context object which limits use-cases. For example, the use-case given by Gregg in solr-user -- http://markmail.org/thread/pu3z27lreefbbkin
> We can add the evaluate method and pass in the Context object. It is a non back-compatible change but since the Evaluator is marked as experimental and it's API has never been documented on the wiki, it should be fine.
> We should also rename it to Function to be consistent with the dataimporter.functions namespace it is used with.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-996) Improve Evaluator API

Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Noble Paul updated SOLR-996:
----------------------------

    Attachment: SOLR-996.patch

> Improve Evaluator API
> ---------------------
>
>                 Key: SOLR-996
>                 URL: https://issues.apache.org/jira/browse/SOLR-996
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.3
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-996.patch
>
>
> An Evaluator does not know about the Context object which limits use-cases. For example, the use-case given by Gregg in solr-user -- http://markmail.org/thread/pu3z27lreefbbkin
> We can add the evaluate method and pass in the Context object. It is a non back-compatible change but since the Evaluator is marked as experimental and it's API has never been documented on the wiki, it should be fine.
> We should also rename it to Function to be consistent with the dataimporter.functions namespace it is used with.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-996) Improve Evaluator API

Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shalin Shekhar Mangar updated SOLR-996:
---------------------------------------

    Attachment: SOLR-996.patch

Patch in sync with trunk and minor javadoc updates.

> Improve Evaluator API
> ---------------------
>
>                 Key: SOLR-996
>                 URL: https://issues.apache.org/jira/browse/SOLR-996
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.3
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-996.patch, SOLR-996.patch
>
>
> An Evaluator does not know about the Context object which limits use-cases. For example, the use-case given by Gregg in solr-user -- http://markmail.org/thread/pu3z27lreefbbkin
> We can add the evaluate method and pass in the Context object. It is a non back-compatible change but since the Evaluator is marked as experimental and it's API has never been documented on the wiki, it should be fine.
> We should also rename it to Function to be consistent with the dataimporter.functions namespace it is used with.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.