You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "hulincup (via GitHub)" <gi...@apache.org> on 2026/08/21 04:43:55 UTC

[PR] Fix #985: Handle PydanticInvalidForJsonSchema for unserializable BaseModel [flink-agents]

hulincup opened a new pull request, #1032:
URL: https://github.com/apache/flink-agents/pull/1032

   ## Description
   
   Fixes #985
   
   When a BaseModel contains fields that cannot be serialized to JSON schema (e.g., `Callable` fields), the `to_strict_json_schema()` function raises `PydanticInvalidForJsonSchema`. Currently, this exception propagates up and breaks the chat call.
   
   The issue description notes that `RowTypeInfo` schemas gracefully fall back to prompt engineering when the connection can't translate them natively, but `BaseModel` schemas that can't be serialized raise an exception instead. This inconsistency should be fixed.
   
   ## Changes
   
   This PR catches `PydanticInvalidForJsonSchema` in the three connection types that use `to_strict_json_schema()` or `transform_schema()`:
   
   1. **OpenAI** (`openai_chat_model.py`):
      - Catches exception in `_native_response_format()`
      - Falls back to prompt engineering (returns `None`)
      - Logs a warning message
      - Added `logger` import
   
   2. **Azure OpenAI** (`azure_openai_chat_model.py`):
      - Catches exception in `_native_response_format()`
      - Falls back to prompt engineering (returns `None`)
      - Logs a warning message
      - Updated docstring to document the fallback behavior
   
   3. **Anthropic** (`anthropic_chat_model.py`):
      - Catches exception in `_native_output_config()`
      - Falls back to prompt engineering (returns `None`)
      - Logs a warning message
      - Updated docstring to document the fallback behavior
   
   ## Testing
   
   Added comprehensive test file `test_unserializable_output_schema.py` with three test cases:
   
   - `test_openai_handles_unserializable_schema()`: Verifies OpenAI falls back to prompt when schema cannot be serialized
   - `test_azure_handles_unserializable_schema()`: Verifies Azure falls back to prompt when schema cannot be serialized
   - `test_anthropic_handles_unserializable_schema()`: Verifies Anthropic falls back to prompt when schema cannot be serialized
   
   Each test uses a `BadModel` with a `Callable` field that cannot be converted to JSON schema, and verifies that:
   1. No exception is raised
   2. The native structured output format is not included in the request (fallback to prompt engineering)
   
   ## Verification
   
   The fix ensures that:
   - Connections handle unserializable `BaseModel` schemas gracefully
   - Behavior is consistent with `RowTypeInfo` fallback
   - Users receive a warning log when fallback occurs
   - Existing functionality for serializable schemas is unchanged
   
   ## Related Issues
   
   - Fixes #985


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix #985: Handle PydanticInvalidForJsonSchema for unserializable BaseModel [flink-agents]

Posted by "hulincup (via GitHub)" <gi...@apache.org>.
hulincup closed pull request #1032: Fix #985: Handle PydanticInvalidForJsonSchema for unserializable BaseModel
URL: https://github.com/apache/flink-agents/pull/1032


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix #985: Handle PydanticInvalidForJsonSchema for unserializable BaseModel [flink-agents]

Posted by "hulincup (via GitHub)" <gi...@apache.org>.
hulincup commented on PR #1032:
URL: https://github.com/apache/flink-agents/pull/1032#issuecomment-5393348401

   Hi @wenjin272, thanks for the heads up.
   
   You're right — #1046 implements option 2 as decided on #985, which is the correct direction. My PR took the fallback approach (option 1), which the discussion on the issue explicitly moved away from on 2026-08-17, so it shouldn't land. I also missed @weiqingy's "I will open a PR" note when I opened this, so the overlap is on me.
   
   Closing #1032 in favor of #1046. Thanks @weiqingy for the thorough implementation across the Python and Java paths.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix #985: Handle PydanticInvalidForJsonSchema for unserializable BaseModel [flink-agents]

Posted by "wenjin272 (via GitHub)" <gi...@apache.org>.
wenjin272 commented on PR #1032:
URL: https://github.com/apache/flink-agents/pull/1032#issuecomment-5392705310

   Thanks for working on this. We have decided on option 2 in #985: an unrenderable schema should raise a clear error, because the prompt fallback also needs to render the schema and therefore cannot handle this case. #1046 implements that approach across the relevant call paths. To avoid duplicate and conflicting fixes, could we close this PR in favor of #1046?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org