You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nitiraj Rathore <ni...@gmail.com> on 2015/11/18 11:14:29 UTC

Review Request 40436: Select on large BIGINT in Ambari Hive View returns incorrect value

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40436/
-----------------------------------------------------------

Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, and Rohit Choudhary.


Bugs: AMBARI-13938
    https://issues.apache.org/jira/browse/AMBARI-13938


Repository: ambari


Description
-------

Server was sending the data properly.
But Javascript does not support number with such large number of digits, so It was approximating.
Changes : 
Now all the data sent will be strings and numbers.


Diffs
-----

  contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/ResultsPaginationController.java 735e63d 

Diff: https://reviews.apache.org/r/40436/diff/


Testing
-------

Manual test from UI and development tools to check if big numbers are coming correctly or not and other funcionalities working properly or not.


Thanks,

Nitiraj Rathore


Re: Review Request 40436: Select on large BIGINT in Ambari Hive View returns incorrect value

Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40436/#review108286
-----------------------------------------------------------

Ship it!


Ship It!

- Jaimin Jetly


On Nov. 18, 2015, 10:20 a.m., Nitiraj Rathore wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40436/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2015, 10:20 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-13938
>     https://issues.apache.org/jira/browse/AMBARI-13938
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Server was sending the data properly.
> But Javascript does not support number with such large number of digits, so It was approximating.
> Changes : 
> Now all the data sent will be strings instead of numbers.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/ResultsPaginationController.java 735e63d 
> 
> Diff: https://reviews.apache.org/r/40436/diff/
> 
> 
> Testing
> -------
> 
> Manual test from UI and development tools to check if big numbers are coming correctly or not and other funcionalities working properly or not.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>


Re: Review Request 40436: Select on large BIGINT in Ambari Hive View returns incorrect value

Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40436/
-----------------------------------------------------------

(Updated Nov. 18, 2015, 10:20 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, and Rohit Choudhary.


Bugs: AMBARI-13938
    https://issues.apache.org/jira/browse/AMBARI-13938


Repository: ambari


Description (updated)
-------

Server was sending the data properly.
But Javascript does not support number with such large number of digits, so It was approximating.
Changes : 
Now all the data sent will be strings instead of numbers.


Diffs
-----

  contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/ResultsPaginationController.java 735e63d 

Diff: https://reviews.apache.org/r/40436/diff/


Testing
-------

Manual test from UI and development tools to check if big numbers are coming correctly or not and other funcionalities working properly or not.


Thanks,

Nitiraj Rathore