[GitHub] [spark] LuciferYang edited a comment on pull request #33556: [SPARK-36324][CORE] Replace revertPartialWritesAndClose with close in ExternalSorter.spill and ExternalAppendOnlyMap.spill

[GitBox <gi...@apache.org>]

LuciferYang edited a comment on pull request #33556:
URL: https://github.com/apache/spark/pull/33556#issuecomment-890792914


   > In general, do not couple implementation details/expectations to general collections.
   > If open() or flush() or close() can result in writes to the file, expectation of revert is to ensure this is discarded; if the code above evolves, we dont want to keep going down the stack to ensure correctness.
   > 
   > Unless I am seeing a logical or performance issue to make this change, I would not make it.
   
   Can you give me more advice so that I can add a case for Spark that can only use the `revertPartialWritesAndClose` when  `objectsWritten = = 0` in this scenario which is also a harvest for me, thx @mridulm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org