You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/06 06:38:07 UTC
[GitHub] [spark] LuciferYang opened a new pull request, #38523: [SPARK-41023][BUILD] Upgrade Jackson to 2.14.0
LuciferYang opened a new pull request, #38523:
URL: https://github.com/apache/spark/pull/38523
### What changes were proposed in this pull request?
This pr aims upgrade `Jackson` related dependencies from 2.13.4 to 2.14.0.
### Why are the changes needed?
After Jackson 2.14.0, all Jackson components required Java 8 except `jackson-annotations`, the release notes as follows:
- https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.14
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass GitHub Actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pjfanning commented on pull request #38523: [SPARK-41023][BUILD] Upgrade Jackson to 2.14.0
Posted by GitBox <gi...@apache.org>.
pjfanning commented on PR #38523:
URL: https://github.com/apache/spark/pull/38523#issuecomment-1304800274
Shouldn't guava changes be done in a separate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pjfanning commented on pull request #38523: [SPARK-41023][BUILD] Upgrade Jackson to 2.14.0
Posted by GitBox <gi...@apache.org>.
pjfanning commented on PR #38523:
URL: https://github.com/apache/spark/pull/38523#issuecomment-1305669441
the byte code generated by Scala 2.13.10 compiler will work with any Scala 2.13.x runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38523: [SPARK-41023][BUILD] Upgrade Jackson to 2.14.0
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38523:
URL: https://github.com/apache/spark/pull/38523#issuecomment-1305671761
@pjfanning Thank you very much
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38523: [SPARK-41023][BUILD] Upgrade Jackson to 2.14.0
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38523:
URL: https://github.com/apache/spark/pull/38523#issuecomment-1305660671
I didn't find the coupling between Jackson 2.14.0 and Guava that Spark depends on from the dependency tree.
However, but I found that `jackson-module-scala_2.13-2.14.0.jar` was compiled by Scala 2.13.10
@srowen Please wait for me to do some compatibility test because Spark depends on Scala 2.13.8 and skips the upgrade of Scala 2.13.10.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #38523: [SPARK-41023][BUILD] Upgrade Jackson to 2.14.0
Posted by GitBox <gi...@apache.org>.
srowen commented on PR #38523:
URL: https://github.com/apache/spark/pull/38523#issuecomment-1304827262
Looks OK if tests pass. I think we need to update the two together, so this resolves both JIRAs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38523: [SPARK-41023][BUILD] Upgrade Jackson to 2.14.0
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38523:
URL: https://github.com/apache/spark/pull/38523#issuecomment-1304922578
@srowen test passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #38523: [SPARK-41023][BUILD] Upgrade Jackson to 2.14.0
Posted by GitBox <gi...@apache.org>.
srowen commented on PR #38523:
URL: https://github.com/apache/spark/pull/38523#issuecomment-1305851364
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bjornjorgensen commented on pull request #38523: [SPARK-41023][BUILD] Upgrade Jackson to 2.14.0
Posted by GitBox <gi...@apache.org>.
bjornjorgensen commented on PR #38523:
URL: https://github.com/apache/spark/pull/38523#issuecomment-1304801289
@pjfanning Yes, but I just wanna ask @LuciferYang if he has been looking at it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38523: [SPARK-41023][BUILD] Upgrade Jackson to 2.14.0
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38523:
URL: https://github.com/apache/spark/pull/38523#issuecomment-1305735206
> unrelated
Thanks for your clarification @bjornjorgensen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #38523: [SPARK-41023][BUILD] Upgrade Jackson to 2.14.0
Posted by GitBox <gi...@apache.org>.
srowen commented on PR #38523:
URL: https://github.com/apache/spark/pull/38523#issuecomment-1305573325
There is no Guava issue here right? just checking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #38523: [SPARK-41023][BUILD] Upgrade Jackson to 2.14.0
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #38523: [SPARK-41023][BUILD] Upgrade Jackson to 2.14.0
URL: https://github.com/apache/spark/pull/38523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pjfanning commented on pull request #38523: [SPARK-41023][BUILD] Upgrade Jackson to 2.14.0
Posted by GitBox <gi...@apache.org>.
pjfanning commented on PR #38523:
URL: https://github.com/apache/spark/pull/38523#issuecomment-1304798867
@LuciferYang feel free to continue with your PR. I marked SPARK-41023 as a duplicate of SPARK-40911.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pjfanning commented on pull request #38523: [SPARK-41023][BUILD] Upgrade Jackson to 2.14.0
Posted by GitBox <gi...@apache.org>.
pjfanning commented on PR #38523:
URL: https://github.com/apache/spark/pull/38523#issuecomment-1305648164
I have no idea why @bjornjorgensen brought up gauva. The comment appears to have been deleted but I received an email notification about a comment made by @bjornjorgensen yesterday afternoon
```
@LuciferYang Have you tried to upgrade guava to 31.1-jre?
```
I can see no reason why guava should be updated as part of this PR and I said that in a previous comment on this PR after I saw the now missing comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bjornjorgensen commented on pull request #38523: [SPARK-41023][BUILD] Upgrade Jackson to 2.14.0
Posted by GitBox <gi...@apache.org>.
bjornjorgensen commented on PR #38523:
URL: https://github.com/apache/spark/pull/38523#issuecomment-1304797597
https://issues.apache.org/jira/browse/SPARK-40911
I think that @pjfanning will work on this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38523: [SPARK-41023][BUILD] Upgrade Jackson to 2.14.0
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38523:
URL: https://github.com/apache/spark/pull/38523#issuecomment-1305585101
Although I think the problems mentioned by @bjornjorgensen @pjfanning are not related to this pr, and the release notes do not mention the constraints of the Guava version, I will double check.
Can you clarify whether the Guava version is related to this pr? @bjornjorgensen @pjfanning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bjornjorgensen commented on pull request #38523: [SPARK-41023][BUILD] Upgrade Jackson to 2.14.0
Posted by GitBox <gi...@apache.org>.
bjornjorgensen commented on PR #38523:
URL: https://github.com/apache/spark/pull/38523#issuecomment-1304798904
@LuciferYang Have you tried to upgrade guava to 31.1-jre?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38523: [SPARK-41023][BUILD] Upgrade Jackson to 2.14.0
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38523:
URL: https://github.com/apache/spark/pull/38523#issuecomment-1304926628
> Shouldn't guava changes be done in a separate PR?
Currently, I will not be considered upgrade Guava for the following reasons:
1. Although Spark 3.4.0 will no longer release the hadoop-2 distribution.sh, but the build and testing process is still going on. We need to keep it and will not consider upgrading Guava until it is really removed
2. In my impression, Hive 2.3 still dependency on the Guava 14.0.1, @sunchao has tried to solve this problem before, but it should not be finished and I don't know whether there are any plans for follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38523: [SPARK-41023][BUILD] Upgrade Jackson to 2.14.0
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38523:
URL: https://github.com/apache/spark/pull/38523#issuecomment-1304926354
> @LuciferYang feel free to continue with your PR. I marked [SPARK-41023](https://issues.apache.org/jira/browse/SPARK-41023) as a duplicate of [SPARK-40911](https://issues.apache.org/jira/browse/SPARK-40911).
Thanks ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38523: [SPARK-41023][BUILD] Upgrade Jackson to 2.14.0
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38523:
URL: https://github.com/apache/spark/pull/38523#issuecomment-1305866017
Thanks @srowen @bjornjorgensen @pjfanning @itholic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38523: [SPARK-41023][BUILD] Upgrade Jackson to 2.14.0
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38523:
URL: https://github.com/apache/spark/pull/38523#issuecomment-1305653320
> I have no idea why @bjornjorgensen brought up gauva. The comment appears to have been deleted but I received an email notification about a comment made by @bjornjorgensen yesterday afternoon
>
> ```
> @LuciferYang Have you tried to upgrade guava to 31.1-jre?
> ```
>
> I can see no reason why guava should be updated as part of this PR and I said that in a previous comment on this PR after I saw the now missing comment.
Thanks for your reply and let us wait for @bjornjorgensen to clarify
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org