You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "waitinfuture (via GitHub)" <gi...@apache.org> on 2023/08/30 03:55:39 UTC

[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1864: [CELEBORN-934] Make the log description in switchServingState more precise

waitinfuture commented on code in PR #1864:
URL: https://github.com/apache/incubator-celeborn/pull/1864#discussion_r1309604847


##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/memory/MemoryManager.java:
##########
@@ -255,12 +255,13 @@ protected void switchServingState() {
     switch (servingState) {
       case PUSH_PAUSED:
         pausePushDataCounter.increment();
-        logger.info("Trigger action: PAUSE PUSH, RESUME REPLICATE");
         if (lastState == ServingState.PUSH_AND_REPLICATE_PAUSED) {
+          logger.info("Trigger action: RESUME REPLICATE");

Review Comment:
   I think the logs can be more precise like:
   `Trigger action: PUSH_AND_REPLICATE_PAUSED -> PUSH_PAUSED`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org