You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/08 13:51:43 UTC

[GitHub] [arrow-datafusion] tustvold commented on a change in pull request #1776: Update `ExecutionPlan` to know about sortedness and repartitioning optimizer pass respect the invariants

tustvold commented on a change in pull request #1776:
URL: https://github.com/apache/arrow-datafusion/pull/1776#discussion_r801650952



##########
File path: datafusion/src/physical_plan/windows/window_agg_exec.rs
##########
@@ -114,6 +115,14 @@ impl ExecutionPlan for WindowAggExec {
         self.input.output_partitioning()
     }
 
+    fn maintains_input_order(&self) -> bool {

Review comment:
       Shouldn't this also have `relies_on_input_order`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org