[GitHub] [incubator-superset] ktmud commented on issue #8638: [wip] superset-ui-plugins linking tool for local development

[GitBox <gi...@apache.org>]

ktmud commented on issue #8638: [wip] superset-ui-plugins linking tool for local development
URL: https://github.com/apache/incubator-superset/pull/8638#issuecomment-587734238
 
 
   Was anyone tempted to move `superset-ui` (especially the visualization registry) and `superset-ui-plugins` (or at least the basic ones) back to the core frontend code? I'm struggling to see the benefit of putting them in separate repos. They are core to Superset's basic functions, not really pluggable, and unlikely to be used by other projects. 
   
   Currently we haven't migrated off the legacy plugins and  the added overhead of syncing package versions, maintaining separate building processes only makes the migration/iterations slower.
   
   Both [Redash](https://github.com/getredash/redash/tree/master/client/app/visualizations) and [Metabase](https://github.com/metabase/metabase/tree/master/frontend/src/metabase/visualizations) didn't take this approach. IMO their visualization registries look much cleaner than Superset and are more developer-friendly to new contributors.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org