You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/01 07:59:52 UTC
[GitHub] [flink] zhuyufeng0809 opened a new pull request, #20126: [FLINK-19651][Connectors/JDBC] Support the filter push down for the JDBC connector
zhuyufeng0809 opened a new pull request, #20126:
URL: https://github.com/apache/flink/pull/20126
## What is the purpose of the change
Support the filter push down for the JDBC connector
## Brief change log
Add some classes to convert expression
## Verifying this change
it works in my company production
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] libenchao commented on pull request #20126: [FLINK-19651][Connectors/JDBC] Support the filter push down for the JDBC connector
Posted by GitBox <gi...@apache.org>.
libenchao commented on PR #20126:
URL: https://github.com/apache/flink/pull/20126#issuecomment-1300604077
@zhuyufeng0809 Sorry that I noticed this issue and PR just now (after I merged https://github.com/apache/flink/pull/20140 and closed https://issues.apache.org/jira/browse/FLINK-16024). I really appreciate your work, but now we have to close this PR since it has been implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuyufeng0809 commented on pull request #20126: [FLINK-19651][Connectors/JDBC] Support the filter push down for the JDBC connector
Posted by GitBox <gi...@apache.org>.
zhuyufeng0809 commented on PR #20126:
URL: https://github.com/apache/flink/pull/20126#issuecomment-1172200472
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] libenchao closed pull request #20126: [FLINK-19651][Connectors/JDBC] Support the filter push down for the JDBC connector
Posted by GitBox <gi...@apache.org>.
libenchao closed pull request #20126: [FLINK-19651][Connectors/JDBC] Support the filter push down for the JDBC connector
URL: https://github.com/apache/flink/pull/20126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #20126: [FLINK-19651][Connectors/JDBC] Support the filter push down for the JDBC connector
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20126:
URL: https://github.com/apache/flink/pull/20126#issuecomment-1172066719
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "98b92c03a4de7a6ae90a9aa4bf6de6f8cdb01c22",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "98b92c03a4de7a6ae90a9aa4bf6de6f8cdb01c22",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 98b92c03a4de7a6ae90a9aa4bf6de6f8cdb01c22 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuyufeng0809 commented on pull request #20126: [FLINK-19651][Connectors/JDBC] Support the filter push down for the JDBC connector
Posted by GitBox <gi...@apache.org>.
zhuyufeng0809 commented on PR #20126:
URL: https://github.com/apache/flink/pull/20126#issuecomment-1176029589
Hi @MartijnVisser , I found that these two issues([FLINK-19651](https://issues.apache.org/jira/browse/FLINK-19651), [FLINK-16024](https://issues.apache.org/jira/browse/FLINK-16024)) are similar, corresponding to this PR and another PR #20140 . now how to deal with this situation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuyufeng0809 commented on pull request #20126: [FLINK-19651][Connectors/JDBC] Support the filter push down for the JDBC connector
Posted by GitBox <gi...@apache.org>.
zhuyufeng0809 commented on PR #20126:
URL: https://github.com/apache/flink/pull/20126#issuecomment-1178649971
Thanks @MartijnVisser , the test of #2005 was really good. Can you review the two PRs first and give some opinions, I think we can extract the advantages of both PRs and refactor them into one PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #20126: [FLINK-19651][Connectors/JDBC] Support the filter push down for the JDBC connector
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #20126:
URL: https://github.com/apache/flink/pull/20126#issuecomment-1177954837
@zhuyufeng0809 @qingwei91 We now have the situation that there are two identical Jira tickets with FLINK-16024 (which was there first) and FLINK-19651 (which is a duplicate). Both have PRs.
Can you collaborate to get to one PR? I do like that https://github.com/apache/flink/pull/20140 has new tests, which is very much appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] qingwei91 commented on pull request #20126: [FLINK-19651][Connectors/JDBC] Support the filter push down for the JDBC connector
Posted by GitBox <gi...@apache.org>.
qingwei91 commented on PR #20126:
URL: https://github.com/apache/flink/pull/20126#issuecomment-1178890761
Hi @zhuyufeng0809 shall we sync up and discuss what to do?
I am in London, so my time zone would be GMT+1, if you're in a similar timezone maybe we can have a call?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org