You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2013/11/20 23:26:41 UTC
Review Request 15731: Refactored Owned and added a function Owned::share().
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15731/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Repository: mesos-git
Description
-------
The 1st patch of the 3 patches that refactored Owned and supported Owned::share().
Diffs
-----
3rdparty/libprocess/Makefile.am d3487802f9b36661162ed2d564db4593a71b3c4b
3rdparty/libprocess/include/process/owned.hpp PRE-CREATION
3rdparty/libprocess/src/tests/owned_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/15731/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 15731: Refactored Owned and added a function
Owned::share().
Posted by Jie Yu <yu...@gmail.com>.
> On Nov. 25, 2013, 1:47 a.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/include/process/owned.hpp, line 103
> > <https://reviews.apache.org/r/15731/diff/1/?file=389059#file389059line103>
> >
> > CHECK_NOTNULL(data->t) << ...
I tried this, and the compiler complained. CHECK_NOTNULL returns a pointer instead of a stream.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15731/#review29351
-----------------------------------------------------------
On Nov. 20, 2013, 10:26 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15731/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2013, 10:26 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The 1st patch of the 3 patches that refactored Owned and supported Owned::share().
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am d3487802f9b36661162ed2d564db4593a71b3c4b
> 3rdparty/libprocess/include/process/owned.hpp PRE-CREATION
> 3rdparty/libprocess/src/tests/owned_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/15731/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 15731: Refactored Owned and added a function
Owned::share().
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15731/#review29351
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/include/process/owned.hpp
<https://reviews.apache.org/r/15731/#comment56545>
CHECK_NOTNULL(data->t) << ...
3rdparty/libprocess/include/process/owned.hpp
<https://reviews.apache.org/r/15731/#comment56546>
Consider CHECK_NOTNULL here too.
- Benjamin Hindman
On Nov. 20, 2013, 10:26 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15731/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2013, 10:26 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The 1st patch of the 3 patches that refactored Owned and supported Owned::share().
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am d3487802f9b36661162ed2d564db4593a71b3c4b
> 3rdparty/libprocess/include/process/owned.hpp PRE-CREATION
> 3rdparty/libprocess/src/tests/owned_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/15731/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 15731: Refactored Owned and added a function
Owned::share().
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15731/
-----------------------------------------------------------
(Updated Nov. 25, 2013, 6:07 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Changes
-------
BenH's comments!
Repository: mesos-git
Description
-------
The 1st patch of the 3 patches that refactored Owned and supported Owned::share().
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am d348780
3rdparty/libprocess/include/process/owned.hpp PRE-CREATION
3rdparty/libprocess/src/tests/owned_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/15731/diff/
Testing
-------
make check
Thanks,
Jie Yu