You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/11/23 10:57:11 UTC

[GitHub] [rocketmq] dingshuangxi888 opened a new pull request #3530: [ISSUE #3527] Fix some request header setting errors and naming issues

dingshuangxi888 opened a new pull request #3530:
URL: https://github.com/apache/rocketmq/pull/3530


   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   
   The header of request code DELETE_TOPIC_IN_NAMESRV(216) is not same in client and the server, It will not cause problems, but should be fixed.
   
   The naming of DeleteTopicInNamesrvRequestHeader should be DeleteTopicFromNamesrvRequestHeader, delete from , not delete in


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] lizhanhui commented on pull request #3530: Fix some request header setting errors and naming issues

Posted by GitBox <gi...@apache.org>.

lizhanhui commented on pull request #3530:
URL: https://github.com/apache/rocketmq/pull/3530#issuecomment-976502467


   Nice catch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] lizhanhui merged pull request #3530: Fix some request header setting errors and naming issues

Posted by GitBox <gi...@apache.org>.

lizhanhui merged pull request #3530:
URL: https://github.com/apache/rocketmq/pull/3530


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] lizhanhui commented on pull request #3530: Fix some request header setting errors and naming issues

Posted by GitBox <gi...@apache.org>.

lizhanhui commented on pull request #3530:
URL: https://github.com/apache/rocketmq/pull/3530#issuecomment-976504666


   Looks good. Considering the changes is relatively small. I would merge it directly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org