[GitHub] [spark] HeartSaVioR commented on a change in pull request #31093: [SPARK-34049][SS] DataSource V2: Use Write abstraction in StreamExecution

[GitBox <gi...@apache.org>]

HeartSaVioR commented on a change in pull request #31093:
URL: https://github.com/apache/spark/pull/31093#discussion_r554276014



##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/connector/InMemoryTable.scala
##########
@@ -274,11 +274,13 @@ class InMemoryTable(
         this
       }
 
-      override def buildForBatch(): BatchWrite = writer

Review comment:
       If I understand correctly, this change is optional (shouldn't break anything even this is not change), as we're trying to guarantee backward compatibility, right? I think it's better to change this - just wanted to check about compatibility.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org