You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/02/17 17:45:00 UTC
[jira] [Work logged] (HIVE-25963) Temporary table creation with not null constraint gets converted to external table
[ https://issues.apache.org/jira/browse/HIVE-25963?focusedWorklogId=729108&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-729108 ]
ASF GitHub Bot logged work on HIVE-25963:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Feb/22 17:44
Start Date: 17/Feb/22 17:44
Worklog Time Spent: 10m
Work Description: sourabh912 opened a new pull request #3040:
URL: https://github.com/apache/hive/pull/3040
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR fixes an issue in which a temporary table when created with not null column constraint, gets converted to external table. It is because HMSClient api createTableWithConstraints() call createTable(createTableRequest) which is not overriden by SessionHiveMetaStoreClient (which handles temporary tables creation/fetch/deletion). As a result of which HMS client makes create_table() RPC call to HMS server which in turn changes the table to external table and also persists its metadata. This is not the desired behavior because temporary tables are stored in memory and the metadata for these should not persisted in HMS.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
It fixes a bug as described in HIVE-25963
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducible example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Enhanced the existing unit tests by adding positive cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 729108)
Remaining Estimate: 0h
Time Spent: 10m
> Temporary table creation with not null constraint gets converted to external table
> -----------------------------------------------------------------------------------
>
> Key: HIVE-25963
> URL: https://issues.apache.org/jira/browse/HIVE-25963
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2, Standalone Metastore
> Reporter: Sourabh Goyal
> Assignee: Sourabh Goyal
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When creating a temporary table with not null, constraint it gets covered to external table. For example:
> create temporary table t2 (a int not null);
> table t2' metadata looks like:
> {code:java}
> +-------------------------------+----------------------------------------------------+----------------------------------------------------+
> | col_name | data_type | comment |
> +-------------------------------+----------------------------------------------------+----------------------------------------------------+
> | a | int | |
> | | NULL | NULL |
> | # Detailed Table Information | NULL | NULL |
> | Database: | default | NULL |
> | OwnerType: | USER | NULL |
> | Owner: | sourabh | NULL |
> | CreateTime: | Tue Feb 15 15:20:13 PST 2022 | NULL |
> | LastAccessTime: | UNKNOWN | NULL |
> | Retention: | 0 | NULL |
> | Location: | hdfs://localhost:9000/tmp/hive/sourabh/80d374a8-cd7a-4fcf-ae72-51b04ff9c3d8/_tmp_space.db/4574446d-c144-48f9-b4b6-2e9ee0ce5be4 | NULL |
> | Table Type: | EXTERNAL_TABLE | NULL |
> | Table Parameters: | NULL | NULL |
> | | COLUMN_STATS_ACCURATE | {\"BASIC_STATS\":\"true\",\"COLUMN_STATS\":{\"a\":\"true\"}} |
> | | EXTERNAL | TRUE |
> | | TRANSLATED_TO_EXTERNAL | TRUE |
> | | bucketing_version | 2 |
> | | external.table.purge | TRUE |
> | | numFiles | 0 |
> | | numRows | 0 |
> | | rawDataSize | 0 |
> | | totalSize | 0 |
> | | transient_lastDdlTime | 1644967213 |
> | | NULL | NULL |
> | # Storage Information | NULL | NULL |
> | SerDe Library: | org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe | NULL |
> | InputFormat: | org.apache.hadoop.mapred.TextInputFormat | NULL |
> | OutputFormat: | org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat | NULL |
> | Compressed: | No | NULL |
> | Num Buckets: | -1 | NULL |
> | Bucket Columns: | [] | NULL |
> | Sort Columns: | [] | NULL |
> | Storage Desc Params: | NULL | NULL |
> | | serialization.format | 1 |
> | | NULL | NULL |
> | # Constraints | NULL | NULL |
> | | NULL | NULL |
> | # Not Null Constraints | NULL | NULL |
> | Table: | default.t2 | NULL |
> | Constraint Name: | nn_157620106_1644967213860_0 | NULL |
> | Column Name: | a | NULL |
> | | NULL | NULL |
> +-------------------------------+----------------------------------------------------+----------------------------------------------------+ {code}
> However if a temporary table is created *without,* not null constraint, it works as expected. For example:
> create temporary table t5 (a int);
>
> {code:java}
> +-------------------------------+----------------------------------------------------+----------------------------------------------------+
> | col_name | data_type | comment |
> +-------------------------------+----------------------------------------------------+----------------------------------------------------+
> | a | int | |
> | | NULL | NULL |
> | # Detailed Table Information | NULL | NULL |
> | Database: | default | NULL |
> | OwnerType: | USER | NULL |
> | Owner: | sourabh | NULL |
> | CreateTime: | Tue Feb 15 15:34:44 PST 2022 | NULL |
> | LastAccessTime: | UNKNOWN | NULL |
> | Retention: | 0 | NULL |
> | Location: | hdfs://localhost:9000/tmp/hive/sourabh/22fcb5c1-b9a6-4d51-8efc-86d7c167a242/_tmp_space.db/0515167f-ca1a-4c53-a1de-e4385fc96079 | NULL |
> | Table Type: | MANAGED_TABLE | NULL |
> | Table Parameters: | NULL | NULL |
> | | COLUMN_STATS_ACCURATE | {\"BASIC_STATS\":\"true\",\"COLUMN_STATS\":{\"a\":\"true\"}} |
> | | bucketing_version | 2 |
> | | numFiles | 0 |
> | | numRows | 0 |
> | | rawDataSize | 0 |
> | | totalSize | 0 |
> | | NULL | NULL |
> | # Storage Information | NULL | NULL |
> | SerDe Library: | org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe | NULL |
> | InputFormat: | org.apache.hadoop.mapred.TextInputFormat | NULL |
> | OutputFormat: | org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat | NULL |
> | Compressed: | No | NULL |
> | Num Buckets: | -1 | NULL |
> | Bucket Columns: | [] | NULL |
> | Sort Columns: | [] | NULL |
> | Storage Desc Params: | NULL | NULL |
> | | serialization.format | 1 |
> +-------------------------------+----------------------------------------------------+----------------------------------------------------+
> {code}
> Temporary tables are managed tables as HS2 keeps them in memory. Their metadata is not persisted in HMS.
> But the above temp table t2 got converted into external table metadata for which gets persisted into HMS which is not the desired behavior.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)