You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Ivan Kelly (JIRA)" <ji...@apache.org> on 2013/05/14 19:05:17 UTC
[jira] [Updated] (BOOKKEEPER-432) Improve performance of entry log
range read per ledger entries
[ https://issues.apache.org/jira/browse/BOOKKEEPER-432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-432:
----------------------------------
Attachment: 0001-BOOKKEEPER-432-First-pass.patch
[~hustlmsp] [~yx3zhu@gmail.com] I've made a first pass on rebasing this on current trunk. I've put it skiplist stuff in a new package to keep things tidy.
SkipListArena.java lacks a license. Is this code copy pasted from somewhere? Can I just put the ASF Licence 2.0 on it?
Some tests are failing with SortedLedgerStorage. I'd like to understand why, and fix them.
I've removed the stats stuff, because that belongs in a separate jira. We need to clean up stats in BK in general anyhow. Currently we only report to JMX and JMX sucks. Perhaps we could use something like Codahale's metrics (http://metrics.codahale.com/ <- seems he works downstairs from you guys).
How have you guys benched this?
> Improve performance of entry log range read per ledger entries
> ---------------------------------------------------------------
>
> Key: BOOKKEEPER-432
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-432
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Affects Versions: 4.2.0
> Environment: Linux
> Reporter: Yixue (Andrew) Zhu
> Assignee: Yixue (Andrew) Zhu
> Labels: patch
> Fix For: 4.3.0
>
> Attachments: 0001-BOOKKEEPER-432-First-pass.patch, BookieLedgerStorageProposal.pdf, PortSkipListLedgerStore.patch
>
>
> We observed random I/O reads when some subscribers fall behind (on some topics), as delivery needs to scan the entry logs (thru ledger index), which are interleaved with ledger entries across all ledgers being served.
> Essentially, the ledger index is a non-clustered index. It is not effective when a large number of ledger entries need to be served, which tend to be scattered around due to interleaving.
> Some possible improvements:
> 1. Change the ledger entries buffer to use a SkipList (or other suitable), sorted on (ledger, entry sequence). When the buffer is flushed, the entry log is written out in the already-sorted order.
> The "active" ledger index can point to the entries buffer (SkipList), and fixed up with entry-log position once latter is persisted.
> Or, the ledger index can be just rebuilt on demand. The entry log file tail can have index attached (light-weight b-tree, similar with big-table). We need to track per ledger which log files contribute entries to it, so that in-memory index can be rebuilt from the tails of corresponding log files.
> 2. Use affinity concept to make ensembles of ledgers (belonging to same topic) as identical as possible. This will help above 1. be more effective.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira