You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2018/04/03 23:10:23 UTC
Review Request 66414: HIVE-17970 MM LOAD DATA with OVERWRITE doesn't
use base_n directory concept
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66414/
-----------------------------------------------------------
Review request for hive and Eugene Koifman.
Repository: hive-git
Description
-------
see jira
Diffs
-----
common/src/java/org/apache/hadoop/hive/common/JavaUtils.java 75c07b41b2
itests/src/test/resources/testconfiguration.properties ec25713906
ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 7eba5e88d8
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 5fbe045df5
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java eed37a1937
ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java e49089b91e
ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java b0dfc48165
ql/src/test/results/clientpositive/mm_loaddata.q.out
Diff: https://reviews.apache.org/r/66414/diff/1/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 66414: HIVE-17970 MM LOAD DATA with OVERWRITE
doesn't use base_n directory concept
Posted by Sergey Shelukhin <se...@hortonworks.com>.
> On April 17, 2018, 3:24 a.m., Eugene Koifman wrote:
> > common/src/java/org/apache/hadoop/hive/common/JavaUtils.java
> > Line 219 (original), 218 (patched)
> > <https://reviews.apache.org/r/66414/diff/2/?file=1993097#file1993097line219>
> >
> > what is the purpose of this if block? seems to do nothing useful
some old code used to rely on this when matching logic was different, to locate (or skip) manifest directories
- Sergey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66414/#review201287
-----------------------------------------------------------
On April 5, 2018, 7:24 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66414/
> -----------------------------------------------------------
>
> (Updated April 5, 2018, 7:24 p.m.)
>
>
> Review request for hive and Eugene Koifman.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/JavaUtils.java 75c07b41b2
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/history/TestHiveHistory.java 0168472bdc
> itests/src/test/resources/testconfiguration.properties d2e077b509
> ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 7eba5e88d8
> ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 5fbe045df5
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java eed37a1937
> ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java e49089b91e
> ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java b0dfc48165
> ql/src/test/results/clientpositive/mm_loaddata.q.out
>
>
> Diff: https://reviews.apache.org/r/66414/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 66414: HIVE-17970 MM LOAD DATA with OVERWRITE
doesn't use base_n directory concept
Posted by Eugene Koifman <ek...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66414/#review201287
-----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/common/JavaUtils.java
Line 200 (original), 200 (patched)
<https://reviews.apache.org/r/66414/#comment282434>
the trailing "_" is probably wrong. Not all deltas have a suffix. delta_x_y is a valid name.
common/src/java/org/apache/hadoop/hive/common/JavaUtils.java
Line 219 (original), 218 (patched)
<https://reviews.apache.org/r/66414/#comment282431>
what is the purpose of this if block? seems to do nothing useful
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
Line 2239 (original), 2211 (patched)
<https://reviews.apache.org/r/66414/#comment282437>
obsolte todo
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
Line 2241 (original), 2213 (patched)
<https://reviews.apache.org/r/66414/#comment282438>
is this todo still meaningfu?
- Eugene Koifman
On April 5, 2018, 12:24 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66414/
> -----------------------------------------------------------
>
> (Updated April 5, 2018, 12:24 p.m.)
>
>
> Review request for hive and Eugene Koifman.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/JavaUtils.java 75c07b41b2
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/history/TestHiveHistory.java 0168472bdc
> itests/src/test/resources/testconfiguration.properties d2e077b509
> ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 7eba5e88d8
> ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 5fbe045df5
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java eed37a1937
> ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java e49089b91e
> ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java b0dfc48165
> ql/src/test/results/clientpositive/mm_loaddata.q.out
>
>
> Diff: https://reviews.apache.org/r/66414/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 66414: HIVE-17970 MM LOAD DATA with OVERWRITE
doesn't use base_n directory concept
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66414/
-----------------------------------------------------------
(Updated April 20, 2018, 11:15 p.m.)
Review request for hive and Eugene Koifman.
Repository: hive-git
Description
-------
see jira
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/JavaUtils.java 7894ec101e
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/history/TestHiveHistory.java 0168472bdc
itests/src/test/resources/testconfiguration.properties 4e7c51926d
ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 6fff7e7421
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 5fbe045df5
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 49c355be01
ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java df2098b0dd
ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java b0dfc48165
ql/src/test/results/clientpositive/mm_loaddata.q.out
Diff: https://reviews.apache.org/r/66414/diff/4/
Changes: https://reviews.apache.org/r/66414/diff/3-4/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 66414: HIVE-17970 MM LOAD DATA with OVERWRITE
doesn't use base_n directory concept
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66414/
-----------------------------------------------------------
(Updated April 18, 2018, 2:42 a.m.)
Review request for hive and Eugene Koifman.
Repository: hive-git
Description
-------
see jira
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/JavaUtils.java 7894ec101e
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/history/TestHiveHistory.java 0168472bdc
itests/src/test/resources/testconfiguration.properties d26f0ccb17
ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 6fff7e7421
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 5fbe045df5
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 009a890888
ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java df2098b0dd
ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java b0dfc48165
ql/src/test/results/clientpositive/mm_loaddata.q.out
Diff: https://reviews.apache.org/r/66414/diff/3/
Changes: https://reviews.apache.org/r/66414/diff/2-3/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 66414: HIVE-17970 MM LOAD DATA with OVERWRITE
doesn't use base_n directory concept
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66414/
-----------------------------------------------------------
(Updated April 5, 2018, 7:24 p.m.)
Review request for hive and Eugene Koifman.
Repository: hive-git
Description
-------
see jira
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/JavaUtils.java 75c07b41b2
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/history/TestHiveHistory.java 0168472bdc
itests/src/test/resources/testconfiguration.properties d2e077b509
ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 7eba5e88d8
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 5fbe045df5
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java eed37a1937
ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java e49089b91e
ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java b0dfc48165
ql/src/test/results/clientpositive/mm_loaddata.q.out
Diff: https://reviews.apache.org/r/66414/diff/2/
Changes: https://reviews.apache.org/r/66414/diff/1-2/
Testing
-------
Thanks,
Sergey Shelukhin