You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "mhlakhani (via GitHub)" <gi...@apache.org> on 2025/07/18 03:01:07 UTC
[PR] [THRIFT-5871] Add message / container size checking for Rust [thrift]
mhlakhani opened a new pull request, #3178:
URL: https://github.com/apache/thrift/pull/3178
<!-- Explain the changes in the pull request below: -->
Bring the Rust implementation somewhat up to par with the other implementations. I tried 4-5 different ways to get the "perfect" check but since trait specialization is not yet stable, I was not able to arrive at a solution I'm happy with (code was either ugly, or had runtime overhead).
So for now, we avoid full message size tracking / more precise limit checking, but this is a strong step in the right direction.
Apologies for the large PR - but most of it is boilerplate (configuration) or semi-exhaustive tests.
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? ([Request account here](https://selfserve.apache.org/jira-account.html), not required for trivial changes)
- [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [THRIFT-5871] Add message / container size checking for Rust [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #3178:
URL: https://github.com/apache/thrift/pull/3178#issuecomment-3094629809
Wild guess: the type 15 is that uuid?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [THRIFT-5871] Add message / container size checking for Rust [thrift]
Posted by "mhlakhani (via GitHub)" <gi...@apache.org>.
mhlakhani commented on PR #3178:
URL: https://github.com/apache/thrift/pull/3178#issuecomment-3092491410
I'll look at the cross test failures -- I can understand the ones with rust involved, the others are a bit surprising.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [THRIFT-5871] Add message / container size checking for Rust [thrift]
Posted by "mhlakhani (via GitHub)" <gi...@apache.org>.
mhlakhani commented on PR #3178:
URL: https://github.com/apache/thrift/pull/3178#issuecomment-3094737081
Submitted a separate PR for the cross tests - they were broken on master: https://github.com/apache/thrift/pull/3179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [THRIFT-5871] Add message / container size checking for Rust [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G merged PR #3178:
URL: https://github.com/apache/thrift/pull/3178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [THRIFT-5871] Add message / container size checking for Rust [thrift]
Posted by "mhlakhani (via GitHub)" <gi...@apache.org>.
mhlakhani commented on PR #3178:
URL: https://github.com/apache/thrift/pull/3178#issuecomment-3094649210
@Jens-G that's likely (and will try to chase this down next week when I have more time) -- but I am trying to understand if this failure is pre-existing on trunk, so I will try to reproduce this locally without my changes, first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [THRIFT-5871] Add message / container size checking for Rust [thrift]
Posted by "mhlakhani (via GitHub)" <gi...@apache.org>.
mhlakhani commented on PR #3178:
URL: https://github.com/apache/thrift/pull/3178#issuecomment-3094705269
@Jens-G I confirmed I can reproduce the same failures (for go,rs) on the master branch so it's unlikely to be affected by my PR. Do we have a tracking ticket for that? I can look into that at some point, separately, but perhaps doesn't make sense to block this PR on that fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org