You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael Busch (JIRA)" <ji...@apache.org> on 2007/04/23 06:40:15 UTC
[jira] Created: (LUCENE-869) Make FSIndexInput and FSIndexOutput
inner classes of FSDirectory
Make FSIndexInput and FSIndexOutput inner classes of FSDirectory
----------------------------------------------------------------
Key: LUCENE-869
URL: https://issues.apache.org/jira/browse/LUCENE-869
Project: Lucene - Java
Issue Type: Improvement
Components: Store
Reporter: Michael Busch
Assigned To: Michael Busch
Priority: Trivial
I would like make FSIndexInput and FSIndexOutput protected, static, inner classes of FSDirectory. Currently these classes are located in the same source file as FSDirectory, which means that classes outside the store package can not extend them.
I don't see any performance impacts or other side effects of this trivial patch. All unit tests pass.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-869) Make FSIndexInput and FSIndexOutput
inner classes of FSDirectory
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Busch updated LUCENE-869:
---------------------------------
Attachment: lucene-869.patch
Attaching the patch file. If nobody objects I'm going to commit this soon.
> Make FSIndexInput and FSIndexOutput inner classes of FSDirectory
> ----------------------------------------------------------------
>
> Key: LUCENE-869
> URL: https://issues.apache.org/jira/browse/LUCENE-869
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Store
> Reporter: Michael Busch
> Assigned To: Michael Busch
> Priority: Trivial
> Attachments: lucene-869.patch
>
>
> I would like make FSIndexInput and FSIndexOutput protected, static, inner classes of FSDirectory. Currently these classes are located in the same source file as FSDirectory, which means that classes outside the store package can not extend them.
> I don't see any performance impacts or other side effects of this trivial patch. All unit tests pass.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-869) Make FSIndexInput and FSIndexOutput
inner classes of FSDirectory
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Busch resolved LUCENE-869.
----------------------------------
Resolution: Fixed
Funny, I didn't even know that nested classes weren't in Java forever...
I just committed this.
> Make FSIndexInput and FSIndexOutput inner classes of FSDirectory
> ----------------------------------------------------------------
>
> Key: LUCENE-869
> URL: https://issues.apache.org/jira/browse/LUCENE-869
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Store
> Reporter: Michael Busch
> Assigned To: Michael Busch
> Priority: Trivial
> Attachments: lucene-869.patch
>
>
> I would like make FSIndexInput and FSIndexOutput protected, static, inner classes of FSDirectory. Currently these classes are located in the same source file as FSDirectory, which means that classes outside the store package can not extend them.
> I don't see any performance impacts or other side effects of this trivial patch. All unit tests pass.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-869) Make FSIndexInput and FSIndexOutput
inner classes of FSDirectory
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12491401 ]
Doug Cutting commented on LUCENE-869:
-------------------------------------
Heh. These classes precede the addition of nested classes to Java. They're nine years old! +1
> Make FSIndexInput and FSIndexOutput inner classes of FSDirectory
> ----------------------------------------------------------------
>
> Key: LUCENE-869
> URL: https://issues.apache.org/jira/browse/LUCENE-869
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Store
> Reporter: Michael Busch
> Assigned To: Michael Busch
> Priority: Trivial
> Attachments: lucene-869.patch
>
>
> I would like make FSIndexInput and FSIndexOutput protected, static, inner classes of FSDirectory. Currently these classes are located in the same source file as FSDirectory, which means that classes outside the store package can not extend them.
> I don't see any performance impacts or other side effects of this trivial patch. All unit tests pass.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org