You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by "maskit (via GitHub)" <gi...@apache.org> on 2023/06/01 21:54:09 UTC

[GitHub] [trafficserver] maskit commented on pull request #9767: Filter SNI based on port

maskit commented on PR #9767:
URL: https://github.com/apache/trafficserver/pull/9767#issuecomment-1572838578

   Almost nitpicking but I wouldn't call the setting value "fqdn". Since this change would be for 10.x, shouldn't we change the setting name accordingly? Also, the setting currently allows using pcre (see #9736). Using a colon for as a delimiter may make the setting parse more complicated. It's probably a time to make an incompatible change and define a clear setting format. IMO, we should not allow pcre.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org