You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/05/10 01:54:18 UTC

[GitHub] [rocketmq] imaffe commented on issue #1852: consumer queue of deleted topic is recovered on DefaultMessageStore#start

imaffe commented on issue #1852:
URL: https://github.com/apache/rocketmq/issues/1852#issuecomment-626260589


   yeah this make sense. Because when we delete a topic we don't delete the entries in the CommitLog, and the ReputMessageService will catch up from CommitLog.
   
   In `doReput()` I didn't see the logic that checks if a CommitLog entry belongs to an existing topic. We might need to validate each CommitLog entry. 
   
   I will look deeper into this issue, I'm reading source code recently so maybe I can help with it a bit.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org