You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@plc4x.apache.org by Julian Feinauer <j....@pragmaticminds.de> on 2020/01/04 19:41:23 UTC

[VOTE] Apache PLC4X Build-Tools Code-Generation 1.1.0 RC1

Hi folks,

as I want to start a release for PLC4X 0.5.1 soon, we need to release the build tools first.
Thus, I hereby start the Vote.

Apache PLC4X Build-Tools Code-Generation 1.1.0 has been staged under [2]
and it’s time to vote on accepting it for release.

All Maven artifacts are available under [1]. Voting will be open for 72hr.

A minimum of 3 binding +1 votes and more binding +1 than binding -1
are required to pass.

Repository: https://gitbox.apache.org/repos/asf/plc4x-build-tools.git
Release tag: release/code-generation/1.1.0
Hash for the release tag: 3b21d09085720f8ab48a294da34d7f9b2fb08de3

Per [3] "Before voting +1 PMC members are required to download
the signed source code package, compile it as provided, and test
the resulting executable on their own platform, along with also
verifying that the package meets the requirements of the ASF policy
on releases."

You can achieve the above by following [4].

[ ]  +1 accept (indicate what you validated - e.g. performed the non-RM items in [4])
[ ]  -1 reject (explanation required)


[1] https://repository.apache.org/content/repositories/orgapacheplc4x-1019
[2] https://dist.apache.org/repos/dist/dev/plc4x/build-tools/code-generation/1.1.0/rc1/
[3] https://www.apache.org/dev/release.html#approving-a-release
[4] https://cwiki.apache.org/confluence/display/PLC4X/Validating+a+staged+Release

AW: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.1.0 RC1

Posted by Julian Feinauer <j....@pragmaticminds.de>.

Hi Justin,

Thanks for the feedback. My last understanding was that it is fine to ship the mvn wrapper but it seems that I was wrong.
I will fix that!

Julian

Von meinem Mobiltelefon gesendet


-------- Ursprüngliche Nachricht --------
Von: Justin Mclean <ju...@classsoftware.com>
Datum: Sa., 4. Jan. 2020, 21:58
An: dev@plc4x.apache.org
Betreff: Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.1.0 RC1
Hi,

-1 (binding) as there is a compiled jar in the source release. [1]

Chris where have I see this same issue before :-)

I checked:
- signatures and hashes are fine
- LICENSE is OK
- NOTICE need year updating
- Unexpected binary fine in the release
- All source  files have ASF headers
- Can compile from source

Thanks,
Justin


1. ./plc4x-code-generaton-1.1.0/.mvn/wrapper/maven-wrapper.jar

Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.1.0 RC1

Posted by Justin Mclean <ju...@classsoftware.com>.

Hi,

-1 (binding) as there is a compiled jar in the source release. [1] 

Chris where have I see this same issue before :-)

I checked:
- signatures and hashes are fine
- LICENSE is OK
- NOTICE need year updating
- Unexpected binary fine in the release
- All source  files have ASF headers
- Can compile from source

Thanks,
Justin


1. ./plc4x-code-generaton-1.1.0/.mvn/wrapper/maven-wrapper.jar

Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.1.0 RC1

Posted by Julian Feinauer <j....@pragmaticminds.de>.

Hi,

my vote is +1 (binding).

I did:
- Checkout all sources
- Verify Hash and Signatures
- Checked all files (README, RELEASE_NOTES, ...); Minor issue: year in NOTICE not updated to 2020
- Performed mvn clean install without issues
- No unexpected binaries
- No files found without valid header
- Found no SNAPSHOT dependencies

Best
Julian

Am 04.01.20, 20:41 schrieb "Julian Feinauer" <j....@pragmaticminds.de>:

    Hi folks,
    
    as I want to start a release for PLC4X 0.5.1 soon, we need to release the build tools first.
    Thus, I hereby start the Vote.
    
    Apache PLC4X Build-Tools Code-Generation 1.1.0 has been staged under [2]
    and it’s time to vote on accepting it for release.
    
    All Maven artifacts are available under [1]. Voting will be open for 72hr.
    
    A minimum of 3 binding +1 votes and more binding +1 than binding -1
    are required to pass.
    
    Repository: https://gitbox.apache.org/repos/asf/plc4x-build-tools.git
    Release tag: release/code-generation/1.1.0
    Hash for the release tag: 3b21d09085720f8ab48a294da34d7f9b2fb08de3
    
    Per [3] "Before voting +1 PMC members are required to download
    the signed source code package, compile it as provided, and test
    the resulting executable on their own platform, along with also
    verifying that the package meets the requirements of the ASF policy
    on releases."
    
    You can achieve the above by following [4].
    
    [ ]  +1 accept (indicate what you validated - e.g. performed the non-RM items in [4])
    [ ]  -1 reject (explanation required)
    
    
    [1] https://repository.apache.org/content/repositories/orgapacheplc4x-1019
    [2] https://dist.apache.org/repos/dist/dev/plc4x/build-tools/code-generation/1.1.0/rc1/
    [3] https://www.apache.org/dev/release.html#approving-a-release
    [4] https://cwiki.apache.org/confluence/display/PLC4X/Validating+a+staged+Release