You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/01/31 01:00:36 UTC
Review Request 65427: Used unique CSI plugin names for SLRP tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65427/
-----------------------------------------------------------
Review request for mesos, Gaston Kleiman and Greg Mann.
Bugs: MESOS-8399
https://issues.apache.org/jira/browse/MESOS-8399
Repository: mesos
Description
-------
To provide better test isolation, the SLRP tests would generate random
unique names in CSI plugin configs, so the plugin containers would use
different container IDs.
Diffs
-----
src/tests/storage_local_resource_provider_tests.cpp e0b089ac96de4762f2c5ddae9716a38d9837d1bf
Diff: https://reviews.apache.org/r/65427/diff/1/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 65427: Used unique CSI plugin names for SLRP tests.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65427/#review196618
-----------------------------------------------------------
Ship it!
Ship It!
- Gaston Kleiman
On Jan. 30, 2018, 5 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65427/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2018, 5 p.m.)
>
>
> Review request for mesos, Gaston Kleiman and Greg Mann.
>
>
> Bugs: MESOS-8399
> https://issues.apache.org/jira/browse/MESOS-8399
>
>
> Repository: mesos
>
>
> Description
> -------
>
> To provide better test isolation, the SLRP tests would generate random
> unique names in CSI plugin configs, so the plugin containers would use
> different container IDs.
>
>
> Diffs
> -----
>
> src/tests/storage_local_resource_provider_tests.cpp e0b089ac96de4762f2c5ddae9716a38d9837d1bf
>
>
> Diff: https://reviews.apache.org/r/65427/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 65427: Used unique CSI plugin names for SLRP tests.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65427/#review196545
-----------------------------------------------------------
PASS: Mesos patch 65427 was successfully built and tested.
Reviews applied: `['65426', '65427']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65427
- Mesos Reviewbot Windows
On Jan. 31, 2018, 1 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65427/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2018, 1 a.m.)
>
>
> Review request for mesos, Gaston Kleiman and Greg Mann.
>
>
> Bugs: MESOS-8399
> https://issues.apache.org/jira/browse/MESOS-8399
>
>
> Repository: mesos
>
>
> Description
> -------
>
> To provide better test isolation, the SLRP tests would generate random
> unique names in CSI plugin configs, so the plugin containers would use
> different container IDs.
>
>
> Diffs
> -----
>
> src/tests/storage_local_resource_provider_tests.cpp e0b089ac96de4762f2c5ddae9716a38d9837d1bf
>
>
> Diff: https://reviews.apache.org/r/65427/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 65427: Used unique CSI plugin names for SLRP tests.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65427/#review196617
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Jan. 31, 2018, 1 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65427/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2018, 1 a.m.)
>
>
> Review request for mesos, Gaston Kleiman and Greg Mann.
>
>
> Bugs: MESOS-8399
> https://issues.apache.org/jira/browse/MESOS-8399
>
>
> Repository: mesos
>
>
> Description
> -------
>
> To provide better test isolation, the SLRP tests would generate random
> unique names in CSI plugin configs, so the plugin containers would use
> different container IDs.
>
>
> Diffs
> -----
>
> src/tests/storage_local_resource_provider_tests.cpp e0b089ac96de4762f2c5ddae9716a38d9837d1bf
>
>
> Diff: https://reviews.apache.org/r/65427/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>