[GitHub] [arrow] alamb commented on a change in pull request #9936: ARROW-12278: [Rust][DataFusion] Use Timestamp(Nanosecond, None) for SQL TIMESTAMP Type

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #9936:
URL: https://github.com/apache/arrow/pull/9936#discussion_r608928102



##########
File path: rust/datafusion/src/execution/context.rs
##########
@@ -2863,10 +2913,7 @@ mod tests {
         ctx: &mut ExecutionContext,
         sql: &str,
     ) -> Result<Vec<RecordBatch>> {
-        let logical_plan = ctx.create_logical_plan(sql)?;

Review comment:
       This is needed so that CREATE EXTERNAL TABLE is handled correctly

##########
File path: rust/datafusion/src/sql/planner.rs
##########
@@ -298,7 +298,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
             SQLDataType::Boolean => Ok(DataType::Boolean),
             SQLDataType::Date => Ok(DataType::Date32),
             SQLDataType::Time => Ok(DataType::Time64(TimeUnit::Millisecond)),
-            SQLDataType::Timestamp => Ok(DataType::Date64),
+            SQLDataType::Timestamp => Ok(DataType::Timestamp(TimeUnit::Nanosecond, None)),

Review comment:
       This is the actual code change in this PR




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org