You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/12/04 11:04:50 UTC

[GitHub] [shardingsphere] codecov-io commented on pull request #8509: Realize the lock confirmation process before executing ddl

codecov-io commented on pull request #8509:
URL: https://github.com/apache/shardingsphere/pull/8509#issuecomment-738721359


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8509?src=pr&el=h1) Report
   > Merging [#8509](https://codecov.io/gh/apache/shardingsphere/pull/8509?src=pr&el=desc) (11bedba) into [master](https://codecov.io/gh/apache/shardingsphere/commit/3363a976140889da693032e9b32f091bceef1949?el=desc) (3363a97) will **decrease** coverage by `0.16%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/8509/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/8509?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #8509      +/-   ##
   ============================================
   - Coverage     72.90%   72.73%   -0.17%     
     Complexity      603      603              
   ============================================
     Files          1533     1533              
     Lines         24284    24312      +28     
     Branches       4272     4280       +8     
   ============================================
   - Hits          17704    17684      -20     
   - Misses         5432     5465      +33     
   - Partials       1148     1163      +15     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8509?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...e/governance/core/lock/GovernanceLockStrategy.java](https://codecov.io/gh/apache/shardingsphere/pull/8509/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9sb2NrL0dvdmVybmFuY2VMb2NrU3RyYXRlZ3kuamF2YQ==) | `26.08% <0.00%> (-73.92%)` | `1.00 <0.00> (ø)` | |
   | [...phere/governance/core/registry/RegistryCenter.java](https://codecov.io/gh/apache/shardingsphere/pull/8509/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9SZWdpc3RyeUNlbnRlci5qYXZh) | `78.94% <0.00%> (-9.29%)` | `0.00 <0.00> (ø)` | |
   | [...e/governance/core/registry/RegistryCenterNode.java](https://codecov.io/gh/apache/shardingsphere/pull/8509/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9SZWdpc3RyeUNlbnRlck5vZGUuamF2YQ==) | `84.61% <0.00%> (-7.06%)` | `0.00 <0.00> (ø)` | |
   | [...hardingsphere/infra/lock/StandardLockStrategy.java](https://codecov.io/gh/apache/shardingsphere/pull/8509/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9sb2NrL1N0YW5kYXJkTG9ja1N0cmF0ZWd5LmphdmE=) | `80.00% <0.00%> (-8.89%)` | `0.00 <0.00> (ø)` | |
   | [...end/communication/DatabaseCommunicationEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/8509/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL0RhdGFiYXNlQ29tbXVuaWNhdGlvbkVuZ2luZS5qYXZh) | `8.23% <0.00%> (-0.74%)` | `0.00 <0.00> (ø)` | |
   | [...re/agent/core/config/AgentConfigurationLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/8509/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jb25maWcvQWdlbnRDb25maWd1cmF0aW9uTG9hZGVyLmphdmE=) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (ø%)` | |
   | [...che/shardingsphere/agent/core/yaml/YamlEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/8509/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS95YW1sL1lhbWxFbmdpbmUuamF2YQ==) | `0.00% <0.00%> (-36.37%)` | `0.00% <0.00%> (ø%)` | |
   | [...osition/resume/ResumeBreakPointManagerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/8509/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvcG9zaXRpb24vcmVzdW1lL1Jlc3VtZUJyZWFrUG9pbnRNYW5hZ2VyRmFjdG9yeS5qYXZh) | `75.00% <0.00%> (-12.50%)` | `0.00% <0.00%> (ø%)` | |
   | [...rdingsphere/proxy/database/DatabaseServerInfo.java](https://codecov.io/gh/apache/shardingsphere/pull/8509/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9kYXRhYmFzZS9EYXRhYmFzZVNlcnZlckluZm8uamF2YQ==) | `90.00% <0.00%> (-10.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...ext/transaction/GovernanceTransactionContexts.java](https://codecov.io/gh/apache/shardingsphere/pull/8509/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvbnRleHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29udGV4dC90cmFuc2FjdGlvbi9Hb3Zlcm5hbmNlVHJhbnNhY3Rpb25Db250ZXh0cy5qYXZh) | `93.33% <0.00%> (-6.67%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [11 more](https://codecov.io/gh/apache/shardingsphere/pull/8509/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8509?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8509?src=pr&el=footer). Last update [3363a97...11bedba](https://codecov.io/gh/apache/shardingsphere/pull/8509?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org