[PATCH] Fix test_lock in the Python bindings testsuite

[Роман Донченко <DX...@yandex.ru>]

Hello,

So the last failing Python test, test_lock, turned out to do something  
odd, namely add a lock with a null lock token. The SQLite schema doesn't  
allow NULLs in the relevant column, which eventually makes the test fail.  
I don't think tokenless locks are supposed to be allowed, so I blame the  
test. The attached patch modifies the test so that it assigns a token to  
the lock first.

I also took the liberty of making it lock a file instead of a directory.  
libsvn_wc can lock a directory, but since Subversion is not really  
supposed to do that, I figured we shouldn't test for it, either. Feel free  
to yell at me if it actually makes sense to lock a directory and I'm  
ruining everything. ;=]

[[[
Fix test_lock in the Python bindings testsuite.

* subversion/bindings/swig/python/tests/wc.py:
   (SubversionWorkingCopyTestCase.test_lock): assign the lock a token, and  
lock /trunk/README.txt instead of /.
]]]

Generally yours,
Roman.

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2368023

Re: [PATCH] Fix test_lock in the Python bindings testsuite

[David James <ja...@gmail.com>]

2009/7/4 Роман Донченко <DX...@yandex.ru>:
> [[[
> Fix test_lock in the Python bindings testsuite.
>
> * subversion/bindings/swig/python/tests/wc.py:
>   (SubversionWorkingCopyTestCase.test_lock): assign the lock a token, and
> lock /trunk/README.txt instead of /.
> ]]]

The patch looks great. Thanks for fixing all the tests! Committed in r38336.

Cheers,

David

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2368046