You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by GitBox <gi...@apache.org> on 2020/09/07 09:53:11 UTC

[GitHub] [karaf] AndreVirtimo opened a new pull request #1188: Fixed image URLs

AndreVirtimo opened a new pull request #1188:
URL: https://github.com/apache/karaf/pull/1188


   Found broken image URLs on https://karaf.apache.org/manual/latest/#_monitoring
   
   I have set the imagesdir attribute in the document. It's also possible to set the URL in the build procees (https://asciidoctor.org/docs/user-manual/#attribute-assignment-precedence).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [karaf] jbonofre commented on pull request #1188: Fixed image URLs

Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #1188:
URL: https://github.com/apache/karaf/pull/1188#issuecomment-692470460


   You should use `git rebase -i` to squash the commits. But nevermind, I will squash myself.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [karaf] AndreVirtimo commented on pull request #1188: Fixed image URLs

Posted by GitBox <gi...@apache.org>.
AndreVirtimo commented on pull request #1188:
URL: https://github.com/apache/karaf/pull/1188#issuecomment-692470952


   Thank you for the tipp.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [karaf] AndreVirtimo commented on pull request #1188: Fixed image URLs

Posted by GitBox <gi...@apache.org>.
AndreVirtimo commented on pull request #1188:
URL: https://github.com/apache/karaf/pull/1188#issuecomment-690098331


   @jbonofre I have rebase my master. I'm not sure if this was the right way. Is it now ok?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [karaf] jbonofre commented on pull request #1188: Fixed image URLs

Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #1188:
URL: https://github.com/apache/karaf/pull/1188#issuecomment-689564833


   @AndreVirtimo can you please rebase from `master` ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [karaf] jbonofre merged pull request #1188: Fixed image URLs

Posted by GitBox <gi...@apache.org>.
jbonofre merged pull request #1188:
URL: https://github.com/apache/karaf/pull/1188


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org