You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by pke <gi...@git.apache.org> on 2015/10/24 00:04:48 UTC

[GitHub] cordova-windows pull request: Replace the "CordovaApp" description...

GitHub user pke opened a pull request:

    https://github.com/apache/cordova-windows/pull/128

    Replace the "CordovaApp" description with the real description from config.xml

    The description was read from the `config.xml` but never used to modify the apps manifest files.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pke/cordova-windows patch-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-windows/pull/128.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #128
    
----
commit f86740a6765d9071711125f396b555ca6817fad4
Author: Philipp Kursawe <ph...@gmail.com>
Date:   2015-10-23T22:04:22Z

    Replace the "CordovaApp" description with the real description from config.xml
    
    The description was read from the `config.xml` but never used to modify the apps manifest files.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-windows pull request: Replace the "CordovaApp" description...

Posted by pke <gi...@git.apache.org>.
Github user pke closed the pull request at:

    https://github.com/apache/cordova-windows/pull/128


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-windows pull request: Replace the "CordovaApp" description...

Posted by pke <gi...@git.apache.org>.
Github user pke commented on the pull request:

    https://github.com/apache/cordova-windows/pull/128#issuecomment-150705390
  
    Hmm something wrong with that. Have to test locally.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org