[jira] [Commented] (HIVE-17637) Refactor WorkloadManager for accessing operations handles in service layer

["Sergey Shelukhin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-17637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16185086#comment-16185086 ] 

Sergey Shelukhin commented on HIVE-17637:
-----------------------------------------

Hmm, the new interface just seems like a passthru. I'd rather not move it to service as it's a major class and this separation is better to do on lower level.
Why does WM need to have access to operations when it already has all its session object?  Note that if elapsed time is implemented, it would need to be enforced before WM even kicks in - at compilation time, in case the time elapses before the end of compile. So either compile would call into WM and WM would need to be extended to track queries during compile, or compile would enforce it separately and can pass a context to WM that would include that start time (for example). This context can be abstract and have a much smaller surface.
For by-user stuff, WM is the wrong place to have it, it only manages queries, not number of connections... again at compile time WM cannot keep track of that. 
While they can reuse rule infra, HS2 will probably call user rule stuff (and global stuff) directly from somewhere else, not via WM, cause it won't involve sessions or anything else WM cares about.


> Refactor WorkloadManager for accessing operations handles in service layer
> --------------------------------------------------------------------------
>
>                 Key: HIVE-17637
>                 URL: https://issues.apache.org/jira/browse/HIVE-17637
>             Project: Hive
>          Issue Type: Sub-task
>    Affects Versions: 3.0.0
>            Reporter: Prasanth Jayachandran
>            Assignee: Prasanth Jayachandran
>         Attachments: HIVE-17637.1.patch
>
>
> There are some rules that has to applied at HS2 service level (connections per user, elapsed time etc.). WM is in ql module which makes it difficult to interact service module.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)