You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@httpd.apache.org by GitBox <gi...@apache.org> on 2021/08/28 05:47:32 UTC
[GitHub] [httpd] jenny-cheung opened a new pull request #263: Fix a small error due to the unreleased lock before program exit.
jenny-cheung opened a new pull request #263:
URL: https://github.com/apache/httpd/pull/263
Around the fixed codes, when `pid == 0`, there is the accept_mutex_off(). However, other places are not. We would like to fix a small error due to the unreleased lock before the program exits in the left place.
It is a small, harmless error since the program exits and all of the program resources will be cleaned up by some common OS. However, other OS systems (e.g., embedded systems) do not automatically free some resources at the exit. It is a good manner for resource management. Adding the unlock statement adds symmetry, so the code looks better. Also, the debugger would not warn this case : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@httpd.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@httpd.apache.org
For additional commands, e-mail: notifications-help@httpd.apache.org
[GitHub] [httpd] ylavic commented on pull request #263: Fix a small error due to the unreleased lock before program exit.
Posted by GitBox <gi...@apache.org>.
ylavic commented on pull request #263:
URL: https://github.com/apache/httpd/pull/263#issuecomment-914117736
Thanks, fixed in 9e02e2000cc05754a9c1c9a9aead7ce2cc8ea6ee
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@httpd.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@httpd.apache.org
For additional commands, e-mail: notifications-help@httpd.apache.org
[GitHub] [httpd] jenny-cheung commented on pull request #263: Fix a small error due to the unreleased lock before program exit.
Posted by GitBox <gi...@apache.org>.
jenny-cheung commented on pull request #263:
URL: https://github.com/apache/httpd/pull/263#issuecomment-914108961
@ylavic Can you take a look? Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@httpd.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@httpd.apache.org
For additional commands, e-mail: notifications-help@httpd.apache.org
[GitHub] [httpd] jenny-cheung closed pull request #263: Fix a small error due to the unreleased lock before program exit.
Posted by GitBox <gi...@apache.org>.
jenny-cheung closed pull request #263:
URL: https://github.com/apache/httpd/pull/263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@httpd.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@httpd.apache.org
For additional commands, e-mail: notifications-help@httpd.apache.org
[GitHub] [httpd] jenny-cheung commented on pull request #263: Fix a small error due to the unreleased lock before program exit.
Posted by GitBox <gi...@apache.org>.
jenny-cheung commented on pull request #263:
URL: https://github.com/apache/httpd/pull/263#issuecomment-915846839
@ylavic Thank you very much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@httpd.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@httpd.apache.org
For additional commands, e-mail: notifications-help@httpd.apache.org