[GitHub] [pulsar] congbobo184 commented on a diff in pull request #19051: [fix][client] retry letter producer respect auto schema

[GitBox <gi...@apache.org>]

congbobo184 commented on code in PR #19051:
URL: https://github.com/apache/pulsar/pull/19051#discussion_r1056922378


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java:
##########
@@ -672,8 +672,10 @@ protected CompletableFuture<Void> doReconsumeLater(Message<?> message, AckType a
                         return null;
                     });
                 } else {
-                    TypedMessageBuilder<T> typedMessageBuilderNew = retryLetterProducer.newMessage()
-                            .value(retryMessage.getValue())
+                    assert retryMessage != null;
+                    TypedMessageBuilder<byte[]> typedMessageBuilderNew = retryLetterProducer
+                            .newMessage(Schema.AUTO_PRODUCE_BYTES(message.getReaderSchema().get()))

Review Comment:
   Unless the user code like this `new TypedMessageBuilderImpl(null, null)` and this is not the `reconsumeLaster` correct use way.
   we use `reconsumeLaster` should use the invoke `consumer.receive()` returned messages,  or construct the correct message yourself



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org