You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/09/02 01:55:31 UTC

[GitHub] [arrow] edponce commented on a change in pull request #11064: ARROW-12657: [C++] Adding String hex to numeric conversion

edponce commented on a change in pull request #11064:
URL: https://github.com/apache/arrow/pull/11064#discussion_r700687522



##########
File path: cpp/src/arrow/util/value_parsing.h
##########
@@ -273,6 +273,96 @@ inline bool ParseUnsigned(const char* s, size_t length, uint64_t* out) {
 #undef PARSE_UNSIGNED_ITERATION
 #undef PARSE_UNSIGNED_ITERATION_LAST
 
+#define PARSE_HEX_ITERATION(C_TYPE)                                     \
+  if (length > 0) {                                                     \

Review comment:
       I suggest to make this a function. The use of macros is undesired in the general case.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org