You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2019/03/07 02:00:46 UTC

[GitHub] [carbondata] qiuchenjian commented on a change in pull request #3140: [CARBONDATA-3307] Fix Performance Issue in No Sort

qiuchenjian commented on a change in pull request #3140: [CARBONDATA-3307] Fix Performance Issue in No Sort
URL: https://github.com/apache/carbondata/pull/3140#discussion_r263211920
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerColumnar.java
 ##########
 @@ -195,7 +195,7 @@ public void initialise() throws CarbonDataWriterException {
    * @param row
    * @throws CarbonDataWriterException
    */
-  public void addDataToStore(CarbonRow row) throws CarbonDataWriterException {
+  public synchronized void addDataToStore(CarbonRow row) throws CarbonDataWriterException {
 
 Review comment:
   I think "synchronized" will decrease the performance while many threads call "addDataToStore",  can you check this scene ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services