You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Hasan Ceylan (JIRA)" <ji...@apache.org> on 2007/11/12 21:29:34 UTC
[jira] Created: (STR-3112) If html:form sets a focus control that
is of array type like radio buttons, generated javascript is wrong
If html:form sets a focus control that is of array type like radio buttons, generated javascript is wrong
---------------------------------------------------------------------------------------------------------
Key: STR-3112
URL: https://issues.apache.org/struts/browse/STR-3112
Project: Struts 1
Issue Type: Bug
Components: Taglibs
Affects Versions: 1.3.9
Environment: All
Reporter: Hasan Ceylan
Priority: Minor
I have a form with radio buttons on it. focus control is set to radio property and focus index is set to 0.
Generated javascript is below. As in this case focus control is array on input objects (radios), styşe check yields to a javascript error...
</form>
<script type="text/javascript" language="JavaScript">
<!--
var focusControl = document.forms["accountForm3"].elements["active"];
if (focusControl.type != "hidden" && !focusControl.disabled && focusControl.style.display != "none") {
focusControl[0].focus();
}
// -->
</script>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-3112) If html:form sets a focus control that
is of array type like radio buttons, generated javascript is wrong
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42636 ]
Paul Benedict commented on STR-3112:
------------------------------------
Do you have a proposed fix? I will patch Struts if you can provide a solution.
> If html:form sets a focus control that is of array type like radio buttons, generated javascript is wrong
> ---------------------------------------------------------------------------------------------------------
>
> Key: STR-3112
> URL: https://issues.apache.org/struts/browse/STR-3112
> Project: Struts 1
> Issue Type: Bug
> Components: Taglibs
> Affects Versions: 1.3.9
> Environment: All
> Reporter: Hasan Ceylan
> Priority: Minor
>
> I have a form with radio buttons on it. focus control is set to radio property and focus index is set to 0.
> Generated javascript is below. As in this case focus control is array on input objects (radios), styşe check yields to a javascript error...
> </form>
> <script type="text/javascript" language="JavaScript">
> <!--
> var focusControl = document.forms["accountForm3"].elements["active"];
> if (focusControl.type != "hidden" && !focusControl.disabled && focusControl.style.display != "none") {
> focusControl[0].focus();
> }
> // -->
> </script>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (STR-3112) Generated javascript is wrong to set
focus on control that is of array
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Benedict resolved STR-3112.
--------------------------------
Resolution: Duplicate
Assignee: Paul Benedict
> Generated javascript is wrong to set focus on control that is of array
> ----------------------------------------------------------------------
>
> Key: STR-3112
> URL: https://issues.apache.org/struts/browse/STR-3112
> Project: Struts 1
> Issue Type: Bug
> Components: Taglibs
> Affects Versions: 1.0.1
> Environment: All
> Reporter: Hasan Ceylan
> Assignee: Paul Benedict
> Priority: Minor
> Fix For: 1.3.10
>
> Attachments: struts_patch.txt
>
>
> I have a form with radio buttons on it. focus control is set to radio property and focus index is set to 0.
> Generated javascript is below. As in this case focus control is array on input objects (radios), styşe check yields to a javascript error...
> </form>
> <script type="text/javascript" language="JavaScript">
> <!--
> var focusControl = document.forms["accountForm3"].elements["active"];
> if (focusControl.type != "hidden" && !focusControl.disabled && focusControl.style.display != "none") {
> focusControl[0].focus();
> }
> // -->
> </script>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (STR-3112) If html:form sets a focus control that
is of array type like radio buttons, generated javascript is wrong
Posted by "Hasan Ceylan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hasan Ceylan updated STR-3112:
------------------------------
Attachment: struts_patch.txt
Hi there,
attached is the patch against Tag 1.3.9 from svn.
I confirm that it is working in my environment.
Any change this patch goes main stream during 1.3.9 release?
Regards,
Hasan Ceylan
> If html:form sets a focus control that is of array type like radio buttons, generated javascript is wrong
> ---------------------------------------------------------------------------------------------------------
>
> Key: STR-3112
> URL: https://issues.apache.org/struts/browse/STR-3112
> Project: Struts 1
> Issue Type: Bug
> Components: Taglibs
> Affects Versions: 1.3.9
> Environment: All
> Reporter: Hasan Ceylan
> Priority: Minor
> Attachments: struts_patch.txt
>
>
> I have a form with radio buttons on it. focus control is set to radio property and focus index is set to 0.
> Generated javascript is below. As in this case focus control is array on input objects (radios), styşe check yields to a javascript error...
> </form>
> <script type="text/javascript" language="JavaScript">
> <!--
> var focusControl = document.forms["accountForm3"].elements["active"];
> if (focusControl.type != "hidden" && !focusControl.disabled && focusControl.style.display != "none") {
> focusControl[0].focus();
> }
> // -->
> </script>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-3112) Generated javascript is wrong to set
focus on control that is of array
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42756 ]
Paul Benedict commented on STR-3112:
------------------------------------
This issue will make it into 1.3.10 and is a duplicate of STR-1496. But you provided a patch and so that means this gets to be fixed.
> Generated javascript is wrong to set focus on control that is of array
> ----------------------------------------------------------------------
>
> Key: STR-3112
> URL: https://issues.apache.org/struts/browse/STR-3112
> Project: Struts 1
> Issue Type: Bug
> Components: Taglibs
> Affects Versions: 1.0.1
> Environment: All
> Reporter: Hasan Ceylan
> Priority: Minor
> Fix For: 1.3.10
>
> Attachments: struts_patch.txt
>
>
> I have a form with radio buttons on it. focus control is set to radio property and focus index is set to 0.
> Generated javascript is below. As in this case focus control is array on input objects (radios), styşe check yields to a javascript error...
> </form>
> <script type="text/javascript" language="JavaScript">
> <!--
> var focusControl = document.forms["accountForm3"].elements["active"];
> if (focusControl.type != "hidden" && !focusControl.disabled && focusControl.style.display != "none") {
> focusControl[0].focus();
> }
> // -->
> </script>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (STR-3112) If html:form sets a focus control that
is of array type like radio buttons, generated javascript is wrong
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Benedict updated STR-3112:
-------------------------------
Affects Version/s: (was: Pending Review)
1.0.1
Fix Version/s: 1.3.10
> If html:form sets a focus control that is of array type like radio buttons, generated javascript is wrong
> ---------------------------------------------------------------------------------------------------------
>
> Key: STR-3112
> URL: https://issues.apache.org/struts/browse/STR-3112
> Project: Struts 1
> Issue Type: Bug
> Components: Taglibs
> Affects Versions: 1.0.1
> Environment: All
> Reporter: Hasan Ceylan
> Priority: Minor
> Fix For: 1.3.10
>
> Attachments: struts_patch.txt
>
>
> I have a form with radio buttons on it. focus control is set to radio property and focus index is set to 0.
> Generated javascript is below. As in this case focus control is array on input objects (radios), styşe check yields to a javascript error...
> </form>
> <script type="text/javascript" language="JavaScript">
> <!--
> var focusControl = document.forms["accountForm3"].elements["active"];
> if (focusControl.type != "hidden" && !focusControl.disabled && focusControl.style.display != "none") {
> focusControl[0].focus();
> }
> // -->
> </script>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (STR-3112) If html:form sets a focus
control that is of array type like radio buttons, generated javascript is
wrong
Posted by "Hasan Ceylan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42676 ]
hceylan@batoo.org edited comment on STR-3112 at 11/16/07 9:25 PM:
-------------------------------------------------------------
Hi there,
attached is the patch against Tag 1.3.9 from svn.
I confirm that it is working in my environment.
Any chance this patch goes main stream during 1.3.9 release?
Regards,
Hasan Ceylan
was (Author: hceylan@batoo.org):
Hi there,
attached is the patch against Tag 1.3.9 from svn.
I confirm that it is working in my environment.
Any change this patch goes main stream during 1.3.9 release?
Regards,
Hasan Ceylan
> If html:form sets a focus control that is of array type like radio buttons, generated javascript is wrong
> ---------------------------------------------------------------------------------------------------------
>
> Key: STR-3112
> URL: https://issues.apache.org/struts/browse/STR-3112
> Project: Struts 1
> Issue Type: Bug
> Components: Taglibs
> Affects Versions: Pending Review
> Environment: All
> Reporter: Hasan Ceylan
> Priority: Minor
> Attachments: struts_patch.txt
>
>
> I have a form with radio buttons on it. focus control is set to radio property and focus index is set to 0.
> Generated javascript is below. As in this case focus control is array on input objects (radios), styşe check yields to a javascript error...
> </form>
> <script type="text/javascript" language="JavaScript">
> <!--
> var focusControl = document.forms["accountForm3"].elements["active"];
> if (focusControl.type != "hidden" && !focusControl.disabled && focusControl.style.display != "none") {
> focusControl[0].focus();
> }
> // -->
> </script>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (STR-3112) If html:form sets a focus control that
is of array type like radio buttons, generated javascript is wrong
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Benedict updated STR-3112:
-------------------------------
Affects Version/s: (was: 1.3.9)
Pending Review
> If html:form sets a focus control that is of array type like radio buttons, generated javascript is wrong
> ---------------------------------------------------------------------------------------------------------
>
> Key: STR-3112
> URL: https://issues.apache.org/struts/browse/STR-3112
> Project: Struts 1
> Issue Type: Bug
> Components: Taglibs
> Affects Versions: Pending Review
> Environment: All
> Reporter: Hasan Ceylan
> Priority: Minor
> Attachments: struts_patch.txt
>
>
> I have a form with radio buttons on it. focus control is set to radio property and focus index is set to 0.
> Generated javascript is below. As in this case focus control is array on input objects (radios), styşe check yields to a javascript error...
> </form>
> <script type="text/javascript" language="JavaScript">
> <!--
> var focusControl = document.forms["accountForm3"].elements["active"];
> if (focusControl.type != "hidden" && !focusControl.disabled && focusControl.style.display != "none") {
> focusControl[0].focus();
> }
> // -->
> </script>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (STR-3112) Generated javascript is wrong to set
focus on control that is of array
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Benedict updated STR-3112:
-------------------------------
Summary: Generated javascript is wrong to set focus on control that is of array (was: If html:form sets a focus control that is of array type like radio buttons, generated javascript is wrong)
> Generated javascript is wrong to set focus on control that is of array
> ----------------------------------------------------------------------
>
> Key: STR-3112
> URL: https://issues.apache.org/struts/browse/STR-3112
> Project: Struts 1
> Issue Type: Bug
> Components: Taglibs
> Affects Versions: 1.0.1
> Environment: All
> Reporter: Hasan Ceylan
> Priority: Minor
> Fix For: 1.3.10
>
> Attachments: struts_patch.txt
>
>
> I have a form with radio buttons on it. focus control is set to radio property and focus index is set to 0.
> Generated javascript is below. As in this case focus control is array on input objects (radios), styşe check yields to a javascript error...
> </form>
> <script type="text/javascript" language="JavaScript">
> <!--
> var focusControl = document.forms["accountForm3"].elements["active"];
> if (focusControl.type != "hidden" && !focusControl.disabled && focusControl.style.display != "none") {
> focusControl[0].focus();
> }
> // -->
> </script>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.