[GitHub] [doris] github-actions[bot] commented on a diff in pull request #14470: [fix](iceberg-v2) icebergv2 filter data path

[GitBox <gi...@apache.org>]

github-actions[bot] commented on code in PR #14470:
URL: https://github.com/apache/doris/pull/14470#discussion_r1044090985


##########
be/src/vec/exec/format/table/iceberg_reader.h:
##########
@@ -23,22 +23,25 @@
 
 #include "table_format_reader.h"
 #include "vec/exec/format/generic_reader.h"
+#include "vec/exprs/vexpr.h"
 
 namespace doris::vectorized {
 
 class IcebergTableReader : public TableFormatReader {
 public:
     IcebergTableReader(GenericReader* file_format_reader, RuntimeProfile* profile,
-                       RuntimeState* state, const TFileScanRangeParams& params)
-            : TableFormatReader(file_format_reader),
-              _profile(profile),
-              _state(state),
-              _params(params) {}
-    Status init_row_filters();
-    void filter_rows() override;
+                       RuntimeState* state, const TFileScanRangeParams& params);
+    ~IcebergTableReader();

Review Comment:
   warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
   
   ```suggestion
       ~IcebergTableReader() override;
   ```
   



##########
be/src/vec/exec/format/table/iceberg_reader.h:
##########
@@ -51,14 +54,23 @@
         int64_t total_file_rows = 0;
     };
 
+private:
+    struct IcebergProfile {
+        RuntimeProfile::Counter* _delete_files_init_time;
+        RuntimeProfile::Counter* _delete_files_read_total_time;
+    };
+
 private:

Review Comment:
   warning: redundant access specifier has the same accessibility as the previous access specifier [readability-redundant-access-specifiers]
   
   ```suggestion
   
   ```
   **be/src/vec/exec/format/table/iceberg_reader.h:56:** previously declared here
   ```cpp
   private:
   ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org