You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/02 09:47:09 UTC
[GitHub] [shardingsphere] natehuangting opened a new pull request, #18155: addComputeNodeInstance when modeType is not cluster
natehuangting opened a new pull request, #18155:
URL: https://github.com/apache/shardingsphere/pull/18155
Fixes #18154 .
Changes proposed in this pull request:
- Execute addComputeNodeInstance when modeType is not cluster, so that some related distsql can be executed in non-cluster mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] natehuangting closed pull request #18155: addComputeNodeInstance when modeType is not cluster
Posted by GitBox <gi...@apache.org>.
natehuangting closed pull request #18155: addComputeNodeInstance when modeType is not cluster
URL: https://github.com/apache/shardingsphere/pull/18155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss commented on a diff in pull request #18155: addComputeNodeInstance when modeType is not cluster
Posted by GitBox <gi...@apache.org>.
menghaoranss commented on code in PR #18155:
URL: https://github.com/apache/shardingsphere/pull/18155#discussion_r887819144
##########
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/instance/InstanceContext.java:
##########
@@ -52,6 +52,9 @@ public InstanceContext(final ComputeNodeInstance instance, final WorkerIdGenerat
this.workerIdGenerator = workerIdGenerator;
this.modeConfiguration = modeConfiguration;
this.lockContext = lockContext;
+ if (!isCluster()) {
Review Comment:
for standalone mode, DistSQL just control the current instance, So there is no need to add instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] natehuangting commented on a diff in pull request #18155: addComputeNodeInstance when modeType is not cluster
Posted by GitBox <gi...@apache.org>.
natehuangting commented on code in PR #18155:
URL: https://github.com/apache/shardingsphere/pull/18155#discussion_r887823796
##########
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/instance/InstanceContext.java:
##########
@@ -52,6 +52,9 @@ public InstanceContext(final ComputeNodeInstance instance, final WorkerIdGenerat
this.workerIdGenerator = workerIdGenerator;
this.modeConfiguration = modeConfiguration;
this.lockContext = lockContext;
+ if (!isCluster()) {
Review Comment:
Maybe in standalone mode, there is no need to check whether the ComputerNodeInstance is consistent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org