[jira] [Commented] (YARN-6175) Negative vcore for resource needed to preempt

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-6175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866573#comment-15866573 ] 

ASF GitHub Bot commented on YARN-6175:
--------------------------------------

GitHub user flyrain opened a pull request:

    https://github.com/apache/hadoop/pull/194

    YARN-6175. Negative vcore for resource needed to preempt.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/flyrain/hadoop yarn-6175

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/hadoop/pull/194.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #194
    
----
commit 1151efe4afb5390c43e61f1b578d5c2772dd9017
Author: Yufei Gu <yu...@cloudera.com>
Date:   2017-02-14T20:22:18Z

    YARN-6175. Negative vcore for resource needed to preempt.

----


> Negative vcore for resource needed to preempt
> ---------------------------------------------
>
>                 Key: YARN-6175
>                 URL: https://issues.apache.org/jira/browse/YARN-6175
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler
>    Affects Versions: 2.8.0, 3.0.0-alpha2
>            Reporter: Yufei Gu
>            Assignee: Yufei Gu
>
> Both old preemption code (2.8 and before) and new preemption code could have negative vcores while calculating resources needed to preempt.
> For old preemption, you can find following messages in RM logs:
> {code}
> Should preempt <memory:2048, vCores:-2> 
> {code}
> The related code is in method {{resourceDeficit()}}. 
> For new preemption code, there are no messages in RM logs, the related code is in method {{fairShareStarvation()}}. 
> The negative value isn't only a display issue, but also may cause missing necessary preemption. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org