You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "MaxGekk (via GitHub)" <gi...@apache.org> on 2023/12/14 15:18:08 UTC
[PR] [WIP][SPARK-46410][SQL] Assign error classes/subclasses to JdbcUtils.classifyException [spark]
MaxGekk opened a new pull request, #44358:
URL: https://github.com/apache/spark/pull/44358
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46410][SQL] Assign error classes/subclasses to JdbcUtils.classifyException [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #44358:
URL: https://github.com/apache/spark/pull/44358#discussion_r1429742582
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -1180,12 +1180,15 @@ object JdbcUtils extends Logging with SQLConfHelper {
}
}
- def classifyException[T](message: String, dialect: JdbcDialect)(f: => T): T = {
+ def classifyException[T](
Review Comment:
when was this API added? @beliefer do you know?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46410][SQL] Assign error classes/subclasses to JdbcUtils.classifyException [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #44358:
URL: https://github.com/apache/spark/pull/44358#discussion_r1429741852
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -1180,12 +1180,15 @@ object JdbcUtils extends Logging with SQLConfHelper {
}
}
- def classifyException[T](message: String, dialect: JdbcDialect)(f: => T): T = {
+ def classifyException[T](
Review Comment:
this is a breaking change, isn't it? JDBCDialect is a public developer API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46410][SQL] Assign error classes/subclasses to JdbcUtils.classifyException [spark]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on code in PR #44358:
URL: https://github.com/apache/spark/pull/44358#discussion_r1429899020
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -1180,12 +1180,15 @@ object JdbcUtils extends Logging with SQLConfHelper {
}
}
- def classifyException[T](message: String, dialect: JdbcDialect)(f: => T): T = {
+ def classifyException[T](
Review Comment:
Perhaps we should keep two versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46410][SQL] Assign error classes/subclasses to JdbcUtils.classifyException [spark]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on code in PR #44358:
URL: https://github.com/apache/spark/pull/44358#discussion_r1427855614
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -1096,6 +1096,79 @@
],
"sqlState" : "38000"
},
+ "FAILED_JDBC" : {
Review Comment:
Just because `FAILED_JDBC` looks confused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46410][SQL] Assign error classes/subclasses to JdbcUtils.classifyException [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #44358:
URL: https://github.com/apache/spark/pull/44358#discussion_r1431044474
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -1180,12 +1180,15 @@ object JdbcUtils extends Logging with SQLConfHelper {
}
}
- def classifyException[T](message: String, dialect: JdbcDialect)(f: => T): T = {
+ def classifyException[T](
Review Comment:
> So if a dialect can classify an exception, we will lose the error class which is actually worse?
@cloud-fan A dialect can override proposed error class and make our default error class more precise using the driver specific info. And yes, the original error class will be lost.
> Can we also enable MiMa for this? I believe this is being skipped because it's under execution package.
@HyukjinKwon I made the modification because MiMa complained. Did you change MiMa to expect different behaviour?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46410][SQL] Assign error classes/subclasses to JdbcUtils.classifyException [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #44358:
URL: https://github.com/apache/spark/pull/44358#discussion_r1429911446
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -1180,12 +1180,15 @@ object JdbcUtils extends Logging with SQLConfHelper {
}
}
- def classifyException[T](message: String, dialect: JdbcDialect)(f: => T): T = {
+ def classifyException[T](
Review Comment:
How about just update the SQL migration guide and ask people to migrate on new version in 4.0.0 (the version can introduce breaking changes).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46410][SQL] Assign error classes/subclasses to JdbcUtils.classifyException [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #44358:
URL: https://github.com/apache/spark/pull/44358#discussion_r1430867300
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -1180,12 +1180,15 @@ object JdbcUtils extends Logging with SQLConfHelper {
}
}
- def classifyException[T](message: String, dialect: JdbcDialect)(f: => T): T = {
+ def classifyException[T](
Review Comment:
Can we also enable MiMa for this? I believe this is being skipped because it's under `execution` package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46410][SQL] Assign error classes/subclasses to JdbcUtils.classifyException [spark]
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on code in PR #44358:
URL: https://github.com/apache/spark/pull/44358#discussion_r1428883906
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -1096,6 +1096,79 @@
],
"sqlState" : "38000"
},
+ "FAILED_JDBC" : {
+ "message" : [
+ "Failed the JDBC operation:"
+ ],
+ "subClass" : {
+ "ALTER_TABLE" : {
+ "message" : [
+ "Alter the table <tableName>."
+ ]
+ },
+ "CREATE_INDEX" : {
+ "message" : [
+ "Create the index <indexName> in the <tableName> table."
+ ]
+ },
+ "CREATE_NAMESPACE" : {
+ "message" : [
+ "Create the namespace <namespace>."
+ ]
+ },
+ "CREATE_NAMESPACE_COMMENT" : {
+ "message" : [
+ "Create a comment on the namespace: <namespace>."
+ ]
+ },
+ "CREATE_TABLE" : {
+ "message" : [
+ "Create the table <tableName>."
+ ]
+ },
+ "DROP_INDEX" : {
+ "message" : [
+ "Drop the index <indexName> in the <tableName> table."
+ ]
+ },
+ "DROP_NAMESPACE" : {
+ "message" : [
+ "Drop the namespace <namespace>."
+ ]
+ },
+ "GET_TABLES" : {
+ "message" : [
+ "Get tables from the namespace: <namespace>."
+ ]
+ },
+ "LIST_NAMESPACES" : {
+ "message" : [
+ "List namespaces."
+ ]
+ },
+ "NAMESPACE_EXISTS" : {
+ "message" : [
+ "Check that the namespace <namespace> exists."
+ ]
+ },
+ "REMOVE_NAMESPACE_COMMENT" : {
+ "message" : [
+ "Remove a comment on the namespace: <namespace>."
+ ]
+ },
+ "RENAME_TABLE" : {
+ "message" : [
+ "Rename the table <oldName> to <newName>."
+ ]
+ },
+ "TABLE_EXISTS" : {
+ "message" : [
+ "Check that the table <tableName> exists."
+ ]
+ }
+ },
+ "sqlState" : "40000"
Review Comment:
Sorry, I fat-fingered. Yes HV000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46410][SQL] Assign error classes/subclasses to JdbcUtils.classifyException [spark]
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on code in PR #44358:
URL: https://github.com/apache/spark/pull/44358#discussion_r1428401767
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -1096,6 +1096,79 @@
],
"sqlState" : "38000"
},
+ "FAILED_JDBC" : {
+ "message" : [
+ "Failed the JDBC operation:"
+ ],
+ "subClass" : {
+ "ALTER_TABLE" : {
+ "message" : [
+ "Alter the table <tableName>."
+ ]
+ },
+ "CREATE_INDEX" : {
+ "message" : [
+ "Create the index <indexName> in the <tableName> table."
+ ]
+ },
+ "CREATE_NAMESPACE" : {
+ "message" : [
+ "Create the namespace <namespace>."
+ ]
+ },
+ "CREATE_NAMESPACE_COMMENT" : {
+ "message" : [
+ "Create a comment on the namespace: <namespace>."
+ ]
+ },
+ "CREATE_TABLE" : {
+ "message" : [
+ "Create the table <tableName>."
+ ]
+ },
+ "DROP_INDEX" : {
+ "message" : [
+ "Drop the index <indexName> in the <tableName> table."
+ ]
+ },
+ "DROP_NAMESPACE" : {
+ "message" : [
+ "Drop the namespace <namespace>."
+ ]
+ },
+ "GET_TABLES" : {
+ "message" : [
+ "Get tables from the namespace: <namespace>."
+ ]
+ },
+ "LIST_NAMESPACES" : {
+ "message" : [
+ "List namespaces."
+ ]
+ },
+ "NAMESPACE_EXISTS" : {
+ "message" : [
+ "Check that the namespace <namespace> exists."
+ ]
+ },
+ "REMOVE_NAMESPACE_COMMENT" : {
+ "message" : [
+ "Remove a comment on the namespace: <namespace>."
+ ]
+ },
+ "RENAME_TABLE" : {
+ "message" : [
+ "Rename the table <oldName> to <newName>."
+ ]
+ },
+ "TABLE_EXISTS" : {
+ "message" : [
+ "Check that the table <tableName> exists."
+ ]
+ }
+ },
+ "sqlState" : "40000"
Review Comment:
I was proposing to replace 40000 with HV004.
This example is interesting. How do we get a 42P07 with FAILED_JDBC errorclass?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46410][SQL] Assign error classes/subclasses to JdbcUtils.classifyException [spark]
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on code in PR #44358:
URL: https://github.com/apache/spark/pull/44358#discussion_r1428334275
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -1096,6 +1096,79 @@
],
"sqlState" : "38000"
},
+ "FAILED_JDBC" : {
+ "message" : [
+ "Failed the JDBC operation:"
+ ],
+ "subClass" : {
+ "ALTER_TABLE" : {
+ "message" : [
+ "Alter the table <tableName>."
+ ]
+ },
+ "CREATE_INDEX" : {
+ "message" : [
+ "Create the index <indexName> in the <tableName> table."
+ ]
+ },
+ "CREATE_NAMESPACE" : {
+ "message" : [
+ "Create the namespace <namespace>."
+ ]
+ },
+ "CREATE_NAMESPACE_COMMENT" : {
+ "message" : [
+ "Create a comment on the namespace: <namespace>."
+ ]
+ },
+ "CREATE_TABLE" : {
+ "message" : [
+ "Create the table <tableName>."
+ ]
+ },
+ "DROP_INDEX" : {
+ "message" : [
+ "Drop the index <indexName> in the <tableName> table."
+ ]
+ },
+ "DROP_NAMESPACE" : {
+ "message" : [
+ "Drop the namespace <namespace>."
+ ]
+ },
+ "GET_TABLES" : {
+ "message" : [
+ "Get tables from the namespace: <namespace>."
+ ]
+ },
+ "LIST_NAMESPACES" : {
+ "message" : [
+ "List namespaces."
+ ]
+ },
+ "NAMESPACE_EXISTS" : {
+ "message" : [
+ "Check that the namespace <namespace> exists."
+ ]
+ },
+ "REMOVE_NAMESPACE_COMMENT" : {
+ "message" : [
+ "Remove a comment on the namespace: <namespace>."
+ ]
+ },
+ "RENAME_TABLE" : {
+ "message" : [
+ "Rename the table <oldName> to <newName>."
+ ]
+ },
+ "TABLE_EXISTS" : {
+ "message" : [
+ "Check that the table <tableName> exists."
+ ]
+ }
+ },
+ "sqlState" : "40000"
Review Comment:
That would be "transaction rollback"
This is all about reaching out to foreign data right?
HV000 FDW-specific condition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46410][SQL] Assign error classes/subclasses to JdbcUtils.classifyException [spark]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on code in PR #44358:
URL: https://github.com/apache/spark/pull/44358#discussion_r1427872206
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -1096,6 +1096,79 @@
],
"sqlState" : "38000"
},
+ "FAILED_JDBC" : {
Review Comment:
I guess the connectivity is not changed if `create index failed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46410][SQL] Assign error classes/subclasses to JdbcUtils.classifyException [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #44358:
URL: https://github.com/apache/spark/pull/44358#issuecomment-1858877929
@srielau @cloud-fan I am going to merge this PR soon if you don't mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46410][SQL] Assign error classes/subclasses to JdbcUtils.classifyException [spark]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on code in PR #44358:
URL: https://github.com/apache/spark/pull/44358#discussion_r1427861122
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala:
##########
@@ -225,40 +225,42 @@ private object PostgresDialect extends JdbcDialect with SQLConfHelper {
s"DROP INDEX ${quoteIdentifier(indexName)}"
}
- override def classifyException(message: String, e: Throwable): AnalysisException = {
+ // Message pattern defined by postgres specification
+ private final val pgAlreadyExistsRegex = """(?:.*)relation "(.*)" already exists""".r
+
+ override def classifyException(
+ e: Throwable,
+ errorClass: String,
+ messageParameters: Map[String, String]): AnalysisException = {
e match {
case sqlException: SQLException =>
sqlException.getSQLState match {
// https://www.postgresql.org/docs/14/errcodes-appendix.html
- case "42P07" =>
- // Message patterns defined at caller sides of spark
- val indexRegex = "(?s)Failed to create index (.*) in (.*)".r
- val renameRegex = "(?s)Failed table renaming from (.*) to (.*)".r
- // Message pattern defined by postgres specification
- val pgRegex = """(?:.*)relation "(.*)" already exists""".r
-
- message match {
- case indexRegex(index, table) =>
- throw new IndexAlreadyExistsException(
- indexName = index, tableName = table, cause = Some(e))
- case renameRegex(_, newTable) =>
- throw QueryCompilationErrors.tableAlreadyExistsError(newTable)
- case _ if pgRegex.findFirstMatchIn(sqlException.getMessage).nonEmpty =>
- val tableName = pgRegex.findFirstMatchIn(sqlException.getMessage).get.group(1)
- throw QueryCompilationErrors.tableAlreadyExistsError(tableName)
- case _ => super.classifyException(message, e)
- }
- case "42704" =>
- // The message is: Failed to drop index indexName in tableName
- val regex = "(?s)Failed to drop index (.*) in (.*)".r
- val indexName = regex.findFirstMatchIn(message).get.group(1)
- val tableName = regex.findFirstMatchIn(message).get.group(2)
+ case "42P07" if errorClass == "FAILED_JDBC.CREATE_INDEX" =>
+ throw new IndexAlreadyExistsException(
+ indexName = messageParameters("indexName"),
+ tableName = messageParameters("tableName"),
+ cause = Some(e))
+ case "42P07" if errorClass == "FAILED_JDBC.RENAME_TABLE" =>
+ val newTable = messageParameters("newName")
+ throw QueryCompilationErrors.tableAlreadyExistsError(newTable)
+ case "42P07" if pgAlreadyExistsRegex.findFirstMatchIn(sqlException.getMessage).nonEmpty =>
+ val tableName = pgAlreadyExistsRegex.findFirstMatchIn(sqlException.getMessage)
Review Comment:
Please make `pgAlreadyExistsRegex.findFirstMatchIn(sqlException.getMessage)` execute only once
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46410][SQL] Assign error classes/subclasses to JdbcUtils.classifyException [spark]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on code in PR #44358:
URL: https://github.com/apache/spark/pull/44358#discussion_r1427819259
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -1096,6 +1096,79 @@
],
"sqlState" : "38000"
},
+ "FAILED_JDBC" : {
Review Comment:
`FAILED_JDBC` -> `FAILED_JDBC_OPERATION`
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala:
##########
@@ -209,25 +212,21 @@ private[sql] object H2Dialect extends JdbcDialect {
throw new NoSuchNamespaceException(errorClass = "SCHEMA_NOT_FOUND",
messageParameters = Map("schemaName" -> quotedName))
// INDEX_ALREADY_EXISTS_1
- case 42111 =>
- // The message is: Failed to create index indexName in tableName
- val regex = "(?s)Failed to create index (.*) in (.*)".r
- val indexName = regex.findFirstMatchIn(message).get.group(1)
- val tableName = regex.findFirstMatchIn(message).get.group(2)
+ case 42111 if errorClass == "FAILED_JDBC.CREATE_INDEX" =>
+ val indexName = messageParameters("indexName")
+ val tableName = messageParameters("tableName")
Review Comment:
Good improvement!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46410][SQL] Assign error classes/subclasses to JdbcUtils.classifyException [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #44358:
URL: https://github.com/apache/spark/pull/44358#discussion_r1429855020
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -1180,12 +1180,15 @@ object JdbcUtils extends Logging with SQLConfHelper {
}
}
- def classifyException[T](message: String, dialect: JdbcDialect)(f: => T): T = {
+ def classifyException[T](
Review Comment:
https://github.com/apache/spark/pull/29952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46410][SQL] Assign error classes/subclasses to JdbcUtils.classifyException [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #44358:
URL: https://github.com/apache/spark/pull/44358#discussion_r1430091874
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -1180,12 +1180,15 @@ object JdbcUtils extends Logging with SQLConfHelper {
}
}
- def classifyException[T](message: String, dialect: JdbcDialect)(f: => T): T = {
+ def classifyException[T](
Review Comment:
I'm wondering if we still need this API in the jdbc dialect. We have the well-defined `FAILED_JDBC` error now, what do we expect the dialect to overwrite?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46410][SQL] Assign error classes/subclasses to JdbcUtils.classifyException [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #44358:
URL: https://github.com/apache/spark/pull/44358#discussion_r1428356377
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -1096,6 +1096,79 @@
],
"sqlState" : "38000"
},
+ "FAILED_JDBC" : {
+ "message" : [
+ "Failed the JDBC operation:"
+ ],
+ "subClass" : {
+ "ALTER_TABLE" : {
+ "message" : [
+ "Alter the table <tableName>."
+ ]
+ },
+ "CREATE_INDEX" : {
+ "message" : [
+ "Create the index <indexName> in the <tableName> table."
+ ]
+ },
+ "CREATE_NAMESPACE" : {
+ "message" : [
+ "Create the namespace <namespace>."
+ ]
+ },
+ "CREATE_NAMESPACE_COMMENT" : {
+ "message" : [
+ "Create a comment on the namespace: <namespace>."
+ ]
+ },
+ "CREATE_TABLE" : {
+ "message" : [
+ "Create the table <tableName>."
+ ]
+ },
+ "DROP_INDEX" : {
+ "message" : [
+ "Drop the index <indexName> in the <tableName> table."
+ ]
+ },
+ "DROP_NAMESPACE" : {
+ "message" : [
+ "Drop the namespace <namespace>."
+ ]
+ },
+ "GET_TABLES" : {
+ "message" : [
+ "Get tables from the namespace: <namespace>."
+ ]
+ },
+ "LIST_NAMESPACES" : {
+ "message" : [
+ "List namespaces."
+ ]
+ },
+ "NAMESPACE_EXISTS" : {
+ "message" : [
+ "Check that the namespace <namespace> exists."
+ ]
+ },
+ "REMOVE_NAMESPACE_COMMENT" : {
+ "message" : [
+ "Remove a comment on the namespace: <namespace>."
+ ]
+ },
+ "RENAME_TABLE" : {
+ "message" : [
+ "Rename the table <oldName> to <newName>."
+ ]
+ },
+ "TABLE_EXISTS" : {
+ "message" : [
+ "Check that the table <tableName> exists."
+ ]
+ }
+ },
+ "sqlState" : "40000"
Review Comment:
> This is all about reaching out to foreign data right?
Right.
> HV000 FDW-specific condition?
Seems like, but what do you propose? to get `sqlState` from `SQLExpression`?
> Is it obvious from the context what we are connecting to?
Should be if an user reads data from one JDBC datasource.
> Should we add some JDBC level context (URL?)
I can extract and pass `option.url` to `AnalysisException` with new error class `FAILED_JDBC` but how about other (classified exceptions) like:
```
case "42P07" =>
if (errorClass == "FAILED_JDBC.CREATE_INDEX") {
throw new IndexAlreadyExistsException(
indexName = messageParameters("indexName"),
tableName = messageParameters("tableName"),
cause = Some(e))
```
The `IndexAlreadyExistsException` has its own error class `INDEX_ALREADY_EXISTS` without any parameters related to JDBC url.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46410][SQL] Assign error classes/subclasses to JdbcUtils.classifyException [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #44358:
URL: https://github.com/apache/spark/pull/44358#discussion_r1427861499
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -1096,6 +1096,79 @@
],
"sqlState" : "38000"
},
+ "FAILED_JDBC" : {
Review Comment:
JDBC means Java Database **Connectivity**, the connectivity might fails at any time, ops or while establishing connections or while keeping it. For instance, this is real example:
```
org.postgresql.util.PSQLException: The connection attempt failed.
at org.postgresql.core.v3.ConnectionFactoryImpl.openConnectionImpl(ConnectionFactoryImpl.java:331)
at org.postgresql.core.ConnectionFactory.openConnection(ConnectionFactory.java:49)
at org.postgresql.jdbc.PgConnection.<init>(PgConnection.java:223)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46410][SQL] Assign error classes/subclasses to JdbcUtils.classifyException [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #44358:
URL: https://github.com/apache/spark/pull/44358#discussion_r1430105163
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -1180,12 +1180,15 @@ object JdbcUtils extends Logging with SQLConfHelper {
}
}
- def classifyException[T](message: String, dialect: JdbcDialect)(f: => T): T = {
+ def classifyException[T](
Review Comment:
> We have the well-defined FAILED_JDBC error now, what do we expect the dialect to overwrite?
We know which operation from Spark side failed but we don't know the root cause of the issue. A dialect can "understand" DBMS specific error better, and map some cases to Spark exceptions. Here is a simple example:
- Spark creates an index, and there is the error class `FAILED_JDBC.CREATE_INDEX` for the cases of any unclassified failures, but
- Postgres dialect knows that the SQL state `42P07` from `SQLException` belongs to existence of the object or in our case it means the index exists already. So, it can provide more precise exception `IndexAlreadyExistsException`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46410][SQL] Assign error classes/subclasses to JdbcUtils.classifyException [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #44358:
URL: https://github.com/apache/spark/pull/44358#issuecomment-1859062970
Merging to master. Thank you, @beliefer @srielau for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46410][SQL] Assign error classes/subclasses to JdbcUtils.classifyException [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #44358:
URL: https://github.com/apache/spark/pull/44358#discussion_r1429905788
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -1180,12 +1180,15 @@ object JdbcUtils extends Logging with SQLConfHelper {
}
}
- def classifyException[T](message: String, dialect: JdbcDialect)(f: => T): T = {
+ def classifyException[T](
Review Comment:
And how will you combine exceptions from the both versions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46410][SQL] Assign error classes/subclasses to JdbcUtils.classifyException [spark]
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on code in PR #44358:
URL: https://github.com/apache/spark/pull/44358#discussion_r1428334275
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -1096,6 +1096,79 @@
],
"sqlState" : "38000"
},
+ "FAILED_JDBC" : {
+ "message" : [
+ "Failed the JDBC operation:"
+ ],
+ "subClass" : {
+ "ALTER_TABLE" : {
+ "message" : [
+ "Alter the table <tableName>."
+ ]
+ },
+ "CREATE_INDEX" : {
+ "message" : [
+ "Create the index <indexName> in the <tableName> table."
+ ]
+ },
+ "CREATE_NAMESPACE" : {
+ "message" : [
+ "Create the namespace <namespace>."
+ ]
+ },
+ "CREATE_NAMESPACE_COMMENT" : {
+ "message" : [
+ "Create a comment on the namespace: <namespace>."
+ ]
+ },
+ "CREATE_TABLE" : {
+ "message" : [
+ "Create the table <tableName>."
+ ]
+ },
+ "DROP_INDEX" : {
+ "message" : [
+ "Drop the index <indexName> in the <tableName> table."
+ ]
+ },
+ "DROP_NAMESPACE" : {
+ "message" : [
+ "Drop the namespace <namespace>."
+ ]
+ },
+ "GET_TABLES" : {
+ "message" : [
+ "Get tables from the namespace: <namespace>."
+ ]
+ },
+ "LIST_NAMESPACES" : {
+ "message" : [
+ "List namespaces."
+ ]
+ },
+ "NAMESPACE_EXISTS" : {
+ "message" : [
+ "Check that the namespace <namespace> exists."
+ ]
+ },
+ "REMOVE_NAMESPACE_COMMENT" : {
+ "message" : [
+ "Remove a comment on the namespace: <namespace>."
+ ]
+ },
+ "RENAME_TABLE" : {
+ "message" : [
+ "Rename the table <oldName> to <newName>."
+ ]
+ },
+ "TABLE_EXISTS" : {
+ "message" : [
+ "Check that the table <tableName> exists."
+ ]
+ }
+ },
+ "sqlState" : "40000"
Review Comment:
That would be "transaction rollback"
This is all about reaching out to foreign data right?
HV000 FDW-specific condition?
Is it obvious from the context what we are connecting to? Should we add some JDBC level context (URL?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46410][SQL] Assign error classes/subclasses to JdbcUtils.classifyException [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #44358:
URL: https://github.com/apache/spark/pull/44358#discussion_r1427825857
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -1096,6 +1096,79 @@
],
"sqlState" : "38000"
},
+ "FAILED_JDBC" : {
Review Comment:
Too long, does `_OPERATION` bring any benefits?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46410][SQL] Assign error classes/subclasses to JdbcUtils.classifyException [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #44358:
URL: https://github.com/apache/spark/pull/44358#discussion_r1431056358
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -1180,12 +1180,15 @@ object JdbcUtils extends Logging with SQLConfHelper {
}
}
- def classifyException[T](message: String, dialect: JdbcDialect)(f: => T): T = {
+ def classifyException[T](
Review Comment:
I think losing the original error class is bad. We added `classifyException` for getting more precise java exception type, but I don't think this is useful anymore as we have error classes. My suggestion is to deprecate `classifyException`, saying that Spark never calls it anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46410][SQL] Assign error classes/subclasses to JdbcUtils.classifyException [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #44358:
URL: https://github.com/apache/spark/pull/44358#discussion_r1428713427
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -1096,6 +1096,79 @@
],
"sqlState" : "38000"
},
+ "FAILED_JDBC" : {
+ "message" : [
+ "Failed the JDBC operation:"
+ ],
+ "subClass" : {
+ "ALTER_TABLE" : {
+ "message" : [
+ "Alter the table <tableName>."
+ ]
+ },
+ "CREATE_INDEX" : {
+ "message" : [
+ "Create the index <indexName> in the <tableName> table."
+ ]
+ },
+ "CREATE_NAMESPACE" : {
+ "message" : [
+ "Create the namespace <namespace>."
+ ]
+ },
+ "CREATE_NAMESPACE_COMMENT" : {
+ "message" : [
+ "Create a comment on the namespace: <namespace>."
+ ]
+ },
+ "CREATE_TABLE" : {
+ "message" : [
+ "Create the table <tableName>."
+ ]
+ },
+ "DROP_INDEX" : {
+ "message" : [
+ "Drop the index <indexName> in the <tableName> table."
+ ]
+ },
+ "DROP_NAMESPACE" : {
+ "message" : [
+ "Drop the namespace <namespace>."
+ ]
+ },
+ "GET_TABLES" : {
+ "message" : [
+ "Get tables from the namespace: <namespace>."
+ ]
+ },
+ "LIST_NAMESPACES" : {
+ "message" : [
+ "List namespaces."
+ ]
+ },
+ "NAMESPACE_EXISTS" : {
+ "message" : [
+ "Check that the namespace <namespace> exists."
+ ]
+ },
+ "REMOVE_NAMESPACE_COMMENT" : {
+ "message" : [
+ "Remove a comment on the namespace: <namespace>."
+ ]
+ },
+ "RENAME_TABLE" : {
+ "message" : [
+ "Rename the table <oldName> to <newName>."
+ ]
+ },
+ "TABLE_EXISTS" : {
+ "message" : [
+ "Check that the table <tableName> exists."
+ ]
+ }
+ },
+ "sqlState" : "40000"
Review Comment:
> I was proposing to replace 40000 with HV004.
@srielau I didn't get the logic why `HV004` but not `HV000`? In postgresql for instance, it is related to `fdw_invalid_data_type`
> How do we get a 42P07 with FAILED_JDBC errorclass?
From the doc https://www.postgresql.org/docs/14/errcodes-appendix.html and experiments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46410][SQL] Assign error classes/subclasses to JdbcUtils.classifyException [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #44358:
URL: https://github.com/apache/spark/pull/44358#discussion_r1428713427
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -1096,6 +1096,79 @@
],
"sqlState" : "38000"
},
+ "FAILED_JDBC" : {
+ "message" : [
+ "Failed the JDBC operation:"
+ ],
+ "subClass" : {
+ "ALTER_TABLE" : {
+ "message" : [
+ "Alter the table <tableName>."
+ ]
+ },
+ "CREATE_INDEX" : {
+ "message" : [
+ "Create the index <indexName> in the <tableName> table."
+ ]
+ },
+ "CREATE_NAMESPACE" : {
+ "message" : [
+ "Create the namespace <namespace>."
+ ]
+ },
+ "CREATE_NAMESPACE_COMMENT" : {
+ "message" : [
+ "Create a comment on the namespace: <namespace>."
+ ]
+ },
+ "CREATE_TABLE" : {
+ "message" : [
+ "Create the table <tableName>."
+ ]
+ },
+ "DROP_INDEX" : {
+ "message" : [
+ "Drop the index <indexName> in the <tableName> table."
+ ]
+ },
+ "DROP_NAMESPACE" : {
+ "message" : [
+ "Drop the namespace <namespace>."
+ ]
+ },
+ "GET_TABLES" : {
+ "message" : [
+ "Get tables from the namespace: <namespace>."
+ ]
+ },
+ "LIST_NAMESPACES" : {
+ "message" : [
+ "List namespaces."
+ ]
+ },
+ "NAMESPACE_EXISTS" : {
+ "message" : [
+ "Check that the namespace <namespace> exists."
+ ]
+ },
+ "REMOVE_NAMESPACE_COMMENT" : {
+ "message" : [
+ "Remove a comment on the namespace: <namespace>."
+ ]
+ },
+ "RENAME_TABLE" : {
+ "message" : [
+ "Rename the table <oldName> to <newName>."
+ ]
+ },
+ "TABLE_EXISTS" : {
+ "message" : [
+ "Check that the table <tableName> exists."
+ ]
+ }
+ },
+ "sqlState" : "40000"
Review Comment:
> I was proposing to replace 40000 with HV004.
I didn't get the logic why `HV004` but not `HV000`? In postgresql for instance, it is related to `fdw_invalid_data_type`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46410][SQL] Assign error classes/subclasses to JdbcUtils.classifyException [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #44358: [SPARK-46410][SQL] Assign error classes/subclasses to JdbcUtils.classifyException
URL: https://github.com/apache/spark/pull/44358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46410][SQL] Assign error classes/subclasses to JdbcUtils.classifyException [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #44358:
URL: https://github.com/apache/spark/pull/44358#discussion_r1430829348
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -1180,12 +1180,15 @@ object JdbcUtils extends Logging with SQLConfHelper {
}
}
- def classifyException[T](message: String, dialect: JdbcDialect)(f: => T): T = {
+ def classifyException[T](
Review Comment:
So if a dialect can classify an exception, we will lose the error class which is actually worse?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46410][SQL] Assign error classes/subclasses to JdbcUtils.classifyException [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #44358:
URL: https://github.com/apache/spark/pull/44358#discussion_r1430444538
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -1180,12 +1180,15 @@ object JdbcUtils extends Logging with SQLConfHelper {
}
}
- def classifyException[T](message: String, dialect: JdbcDialect)(f: => T): T = {
+ def classifyException[T](
Review Comment:
so what we end up with is a nested exception? I still don't quite understand how these two work together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org